Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2717233003: gpu: Use mojom API for getting video memory usage. (Closed)

Created:
3 years, 9 months ago by sadrul
Modified:
3 years, 9 months ago
Reviewers:
Tom Sepez, jbauman
CC:
chromium-reviews, rjkroege, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, piman+watch_chromium.org, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu: Use mojom API for getting video memory usage. Continue to replace chrome IPC messages with corresponding mojo API used for mus. This CL removes the messages for getting the video memory usage stats. BUG=643746, 630895 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2717233003 Cr-Commit-Position: refs/heads/master@{#453816} Committed: https://chromium.googlesource.com/chromium/src/+/3ab0a53354e466b4da17cce0f7e59def76fc6190

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -45 lines) Patch
M content/browser/gpu/gpu_data_manager_impl_private.cc View 2 chunks +11 lines, -2 lines 0 comments Download
M content/browser/gpu/gpu_process_host.h View 1 2 3 4 2 chunks +9 lines, -0 lines 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 2 chunks +18 lines, -0 lines 0 comments Download
M content/browser/gpu/gpu_process_host_ui_shim.h View 2 chunks +0 lines, -6 lines 0 comments Download
M content/browser/gpu/gpu_process_host_ui_shim.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M content/common/gpu_host_messages.h View 3 chunks +0 lines, -17 lines 0 comments Download
M content/gpu/gpu_child_thread.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/gpu/gpu_child_thread.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M gpu/ipc/common/BUILD.gn View 1 2 3 3 chunks +3 lines, -0 lines 0 comments Download
M gpu/ipc/common/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
A gpu/ipc/common/memory_stats.mojom View 1 chunk +15 lines, -0 lines 0 comments Download
A gpu/ipc/common/memory_stats.typemap View 1 2 3 4 1 chunk +11 lines, -0 lines 0 comments Download
A gpu/ipc/common/memory_stats_struct_traits.h View 1 2 3 4 1 chunk +72 lines, -0 lines 0 comments Download
M gpu/ipc/common/typemaps.gni View 1 chunk +1 line, -0 lines 0 comments Download
M services/ui/gpu/gpu_service.h View 1 chunk +2 lines, -0 lines 0 comments Download
M services/ui/gpu/gpu_service.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M services/ui/gpu/interfaces/gpu_service.mojom View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 29 (24 generated)
sadrul
tsepez@ for ipc changes (.mojom, struct_traits, and messages.h) jbauman@ for the rest of it.
3 years, 9 months ago (2017-02-28 04:19:14 UTC) #20
Tom Sepez
lgtm
3 years, 9 months ago (2017-02-28 18:02:54 UTC) #23
jbauman
lgtm
3 years, 9 months ago (2017-02-28 23:13:38 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2717233003/80001
3 years, 9 months ago (2017-03-01 02:17:52 UTC) #26
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 03:17:24 UTC) #29
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/3ab0a53354e466b4da17cce0f7e5...

Powered by Google App Engine
This is Rietveld 408576698