Chromium Code Reviews| Index: chrome/browser/resources/chromeos/braille_ime/braille_ime_unittest.gtestjs |
| diff --git a/chrome/browser/resources/chromeos/braille_ime/braille_ime_unittest.gtestjs b/chrome/browser/resources/chromeos/braille_ime/braille_ime_unittest.gtestjs |
| index 9a249da76627e55c5d840799f9fa9c383f347cc4..b16fe446b2377fad1144d3cb955fba6df267b374 100644 |
| --- a/chrome/browser/resources/chromeos/braille_ime/braille_ime_unittest.gtestjs |
| +++ b/chrome/browser/resources/chromeos/braille_ime/braille_ime_unittest.gtestjs |
| @@ -122,12 +122,20 @@ BrailleImeUnitTest.prototype = { |
| this.port.messages.length = 0; |
| }, |
| - sendKeyDown: function(code) { |
| - return this.onKeyEvent.dispatch(ENGINE_ID, {code: code, type: 'keydown'}); |
| + sendKeyDown: function(code, extra) { |
| + var event = {code: code, type: 'keydown'}; |
| + for (var key in extra) { |
| + event[key] = extra[key]; |
| + } |
| + return this.onKeyEvent.dispatch(ENGINE_ID, event); |
| }, |
| - sendKeyUp: function(code) { |
| - return this.onKeyEvent.dispatch(ENGINE_ID, {code: code, type: 'keyup'}); |
| + sendKeyUp: function(code, extra) { |
| + var event = {code: code, type: 'keyup'}; |
| + for (var key in extra) { |
| + event[key] = extra[key]; |
| + } |
| + return this.onKeyEvent.dispatch(ENGINE_ID, event); |
| }, |
| }; |
| @@ -154,6 +162,7 @@ TEST_F('BrailleImeUnitTest', 'KeysWhenStandardKeysEnabled', function() { |
| expectTrue(this.sendKeyDown('KeyF')); |
| expectTrue(this.sendKeyUp('KeyJ')); |
| expectTrue(this.sendKeyUp('KeyF')); |
| + |
| // Make sure that other keys are not handled, either by themselves or while |
| // one of the 'braille keys' is pressed. |
| expectFalse(this.sendKeyDown('KeyX')); |
| @@ -164,6 +173,13 @@ TEST_F('BrailleImeUnitTest', 'KeysWhenStandardKeysEnabled', function() { |
| expectTrue(this.sendKeyUp('KeyS')); |
| expectFalse(this.sendKeyUp('KeyG')); |
| + // Keys like Ctrl L should not be handled, despite L being a dot key. |
| + var ctrlFlag = {ctrlKey: true}; |
| + expectFalse(this.sendKeyDown('ControlLeft', ctrlFlag)); |
| + expectFalse(this.sendKeyDown('KeyL', ctrlFlag)); |
| + expectFalse(this.sendKeyUp('KeyL', ctrlFlag)); |
| + expectFalse(this.sendKeyUp('ControlLeft', ctrlFlag)) |
| + |
| assertThat(this.port.messages, |
|
David Tseng
2014/05/07 18:05:54
I was expecting a test for the space key behavior
|
| eqJSON([{type: 'brailleDots', dots: 0x03}, |
| {type: 'brailleDots', dots: 0x09}])); |