Make Braille IME send space bar as an empty cell instead of letting propagate.

chrome/browser/resources/chromeos/braille_ime/braille_ime_unittest.gtestjs

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview Unit test for the Braille IME.
  */
 
 /**
  * Mock Chrome event supporting one listener.
@@ skipping 104 matching lines @@
     this.ime.init();
   },
 
   activateIme: function() {
     this.onActivate.dispatch(ENGINE_ID);
     assertThat(this.port.messages,
                eqJSON([{type: 'activeState', active: true}]));
     this.port.messages.length = 0;
   },
 
-  sendKeyDown: function(code) {
-    return this.onKeyEvent.dispatch(ENGINE_ID, {code: code, type: 'keydown'});
+  sendKeyDown: function(code, extra) {
+    var event = {code: code, type: 'keydown'};
+    for (var key in extra) {
+      event[key] = extra[key];
+    }
+    return this.onKeyEvent.dispatch(ENGINE_ID, event);
   },
 
-  sendKeyUp: function(code) {
-    return this.onKeyEvent.dispatch(ENGINE_ID, {code: code, type: 'keyup'});
+  sendKeyUp: function(code, extra) {
+    var event = {code: code, type: 'keyup'};
+    for (var key in extra) {
+      event[key] = extra[key];
+    }
+    return this.onKeyEvent.dispatch(ENGINE_ID, event);
   },
 };
 
 TEST_F('BrailleImeUnitTest', 'KeysWhenStandardKeyboardDisabled', function() {
   this.activateIme();
   expectFalse(this.sendKeyDown('KeyF'));
   expectFalse(this.sendKeyDown('KeyD'));
   expectFalse(this.sendKeyUp('KeyD'));
   expectFalse(this.sendKeyUp('KeyF'));
   expectEquals(0, this.port.messages.length);
 });
 
 TEST_F('BrailleImeUnitTest', 'KeysWhenStandardKeysEnabled', function() {
   this.activateIme();
   assertFalse(this.menuItems[0].checked);
   this.onMenuItemActivated.dispatch(ENGINE_ID, this.menuItems[0].id);
   assertTrue(this.menuItems[0].checked);
   // Type the letters 'b' and 'c' and verify the right dots get sent.
   expectTrue(this.sendKeyDown('KeyF'));
   expectTrue(this.sendKeyDown('KeyD'));
   expectTrue(this.sendKeyUp('KeyD'));
   expectTrue(this.sendKeyUp('KeyF'));
   expectTrue(this.sendKeyDown('KeyJ'));
   expectTrue(this.sendKeyDown('KeyF'));
   expectTrue(this.sendKeyUp('KeyJ'));
   expectTrue(this.sendKeyUp('KeyF'));
+
   // Make sure that other keys are not handled, either by themselves or while
   // one of the 'braille keys' is pressed.
   expectFalse(this.sendKeyDown('KeyX'));
   expectFalse(this.sendKeyUp('KeyX'));
 
   expectTrue(this.sendKeyDown('KeyS'));  // Dot 3
   expectFalse(this.sendKeyDown('KeyG'));  // To the right of dot 1.
   expectTrue(this.sendKeyUp('KeyS'));
   expectFalse(this.sendKeyUp('KeyG'));
 
+  // Keys like Ctrl L should not be handled, despite L being a dot key.
+  var ctrlFlag = {ctrlKey: true};
+  expectFalse(this.sendKeyDown('ControlLeft', ctrlFlag));
+  expectFalse(this.sendKeyDown('KeyL', ctrlFlag));
+  expectFalse(this.sendKeyUp('KeyL', ctrlFlag));
+  expectFalse(this.sendKeyUp('ControlLeft', ctrlFlag))
+
   assertThat(this.port.messages,

[David Tseng, 2014/05/07 18:05:54]

I was expecting a test for the space key behavior introduced by this cl.

              eqJSON([{type: 'brailleDots', dots: 0x03},
                      {type: 'brailleDots', dots: 0x09}]));
 });
 
 TEST_F('BrailleImeUnitTest', 'UseStandardKeyboardSettingPreserved', function() {
   this.activateIme();
   assertFalse(this.menuItems[0].checked);
   this.onMenuItemActivated.dispatch(ENGINE_ID, this.menuItems[0].id);
   assertTrue(this.menuItems[0].checked);
   // Create a new instance and make sure the setting is still turned on.
@@ skipping 29 matching lines @@
        deleteBefore: deleteBefore, newText: newText});
   }.bind(this);
   this.activateIme();
   sendReplaceText(0, 'hello!');
   assertEquals('Hi, hello!', text);
   hasSelection = true;
   sendReplaceText('hello!'.length, 'good bye!');
   assertFalse(hasSelection);
   assertEquals('Hi, good bye!', text);
 });