Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2717203002: [StoreIC] Use StoreIC_Uninitialized for 0->PRE transitions (Closed)

Created:
3 years, 9 months ago by Jakob Kummerow
Modified:
3 years, 9 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[StoreIC] Use StoreIC_Uninitialized for 0->PRE transitions Avoiding runtime call overhead. BUG=v8:5269 Review-Url: https://codereview.chromium.org/2717203002 Cr-Commit-Position: refs/heads/master@{#43799} Committed: https://chromium.googlesource.com/v8/v8/+/391c967c92716b4983ac097c8fa8ab4d204f7afe

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : rebased #

Patch Set 4 : check for map extensibility #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -11 lines) Patch
M src/builtins/builtins.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M src/builtins/builtins-handler.cc View 1 1 chunk +10 lines, -0 lines 0 comments Download
M src/code-factory.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/code-factory.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download
M src/ic/accessor-assembler.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/ic/accessor-assembler.cc View 1 2 3 chunks +16 lines, -5 lines 0 comments Download
M src/ic/keyed-store-generic.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/ic/keyed-store-generic.cc View 1 2 3 8 chunks +65 lines, -5 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
Igor Sheludko
lgtm
3 years, 9 months ago (2017-03-03 08:26:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2717203002/20001
3 years, 9 months ago (2017-03-14 13:10:33 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/builds/18420) v8_linux64_avx2_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
3 years, 9 months ago (2017-03-14 13:28:43 UTC) #7
Igor Sheludko
lgtm
3 years, 9 months ago (2017-03-14 16:12:08 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2717203002/60001
3 years, 9 months ago (2017-03-14 16:53:02 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 16:59:28 UTC) #17
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/391c967c92716b4983ac097c8fa8ab4d204...

Powered by Google App Engine
This is Rietveld 408576698