[tab_container] Hack-in fix for broken constraint on animation

[tab_container] Hack-in fix for broken constraint on animation

Custom view controller transition animations must be designed
so as not to break constraints on the presented/dismissed VC's view.

This CL addresses a broken constraint due to the zoom animator. 
The zoom animator will resize the VC's view to a small rect. 
However, that rect is smaller in height than the sum of the 
height constraints on the subviews of the tab_container. 

This CL simply reduces the subview height constant. Since the
transition animation will likely change, there is no need to modify 
the zoom animator at this time. 

BUG=

Review-Url: https://codereview.chromium.org/2717133002
Cr-Commit-Position: refs/heads/master@{#453249}
Committed: https://chromium.googlesource.com/chromium/src/+/1bcc418f288f8b84643f0f8b34cbe7eb0fd548bd

[edchin, 2017-02-26 07:24:24]

Description was changed from

==========
[tab_container] Hack-in fix for broken constraint on animation

BUG=
==========

to

==========
[tab_container] Hack-in fix for broken constraint on animation

Custom view controller transition animations must be designed
so as not to break constraints on the presented/dismissed VC's view.

This CL addresses a broken constraint due to the zoom animator. 
The zoom animator will resize the VC's view to a small rect. 
However, that rect is smaller in height than the sum of the 
height constraints on the subviews of the tab_container. 

This CL simply reduces the subview height constant. Since the
transition animation will likely change, there is no need to modify 
the zoom animator at this time. 

BUG=
==========

[edchin, 2017-02-26 07:24:24]

edchin@chromium.org changed reviewers:
+ lpromero@chromium.org, marq@chromium.org, sczs@chromium.org

[edchin, 2017-02-26 07:26:19]

The CQ bit was checked by edchin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-26 07:26:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-26 07:38:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-26 07:38:25]

Dry run: This issue passed the CQ dry run.

[sczs, 2017-02-27 16:04:28]

lgtm

I was seeing that issue as well, I think is a good solution especially for now!
Thanks for fixing this.

[marq (ping after 24h), 2017-02-27 16:35:15]

LGTM.

The zoom animator should eventually use some combination of resizing (to set the
aspect ratio) and scaling via transform.

[edchin, 2017-02-27 17:38:42]

The CQ bit was checked by edchin@chromium.org

[commit-bot: I haz the power, 2017-02-27 17:40:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 17:53:12]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1488217122662680, "parent_rev":
"393f08e143d2d7c6d84744221db39516474fb159", "commit_rev":
"1bcc418f288f8b84643f0f8b34cbe7eb0fd548bd"}

[commit-bot: I haz the power, 2017-02-27 17:54:03]

Description was changed from

==========
[tab_container] Hack-in fix for broken constraint on animation

Custom view controller transition animations must be designed
so as not to break constraints on the presented/dismissed VC's view.

This CL addresses a broken constraint due to the zoom animator. 
The zoom animator will resize the VC's view to a small rect. 
However, that rect is smaller in height than the sum of the 
height constraints on the subviews of the tab_container. 

This CL simply reduces the subview height constant. Since the
transition animation will likely change, there is no need to modify 
the zoom animator at this time. 

BUG=
==========

to

==========
[tab_container] Hack-in fix for broken constraint on animation

Custom view controller transition animations must be designed
so as not to break constraints on the presented/dismissed VC's view.

This CL addresses a broken constraint due to the zoom animator. 
The zoom animator will resize the VC's view to a small rect. 
However, that rect is smaller in height than the sum of the 
height constraints on the subviews of the tab_container. 

This CL simply reduces the subview height constant. Since the
transition animation will likely change, there is no need to modify 
the zoom animator at this time. 

BUG=

Review-Url: https://codereview.chromium.org/2717133002
Cr-Commit-Position: refs/heads/master@{#453249}
Committed:
https://chromium.googlesource.com/chromium/src/+/1bcc418f288f8b84643f0f8b34cb...
==========

[commit-bot: I haz the power, 2017-02-27 17:54:04]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1bcc418f288f8b84643f0f8b34cb...