Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issue 271703012: Remove SCM_CREDENTIALS fallback code from breakpad (Closed)

Created:
6 years, 7 months ago by mdempsky
Modified:
6 years, 7 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Remove SCM_CREDENTIALS fallback code from breakpad Since r266618, we require SCM_CREDENTIALS to work correctly across PID namespaces, and refuse to run on kernels where it doesn't. Reland of r270173. The original attempt failed to update kControlMsgSize, which caused failures like this one: http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/5169 This is only noticed on 32-bit machines because CMSG_SPACE(sizeof(int)) happens to equal CMSG_SPACE(2*sizeof(int)) on x86-64 due to structure padding and alignment, but they're different on i386. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270367

Patch Set 1 #

Patch Set 2 : Fix kControlMsgSize #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -169 lines) Patch
M base/linux_util.h View 1 chunk +0 lines, -7 lines 0 comments Download
M base/linux_util.cc View 2 chunks +0 lines, -121 lines 0 comments Download
M components/breakpad/app/breakpad_linux.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M components/breakpad/browser/crash_handler_host_linux.cc View 1 5 chunks +4 lines, -38 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
mdempsky
As requested, patch set 1 is the original erroneous commit.
6 years, 7 months ago (2014-05-14 05:38:41 UTC) #1
Lei Zhang
lgtm
6 years, 7 months ago (2014-05-14 05:53:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mdempsky@chromium.org/271703012/20001
6 years, 7 months ago (2014-05-14 05:53:58 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-14 07:37:35 UTC) #4
commit-bot: I haz the power
Change committed as 270367
6 years, 7 months ago (2014-05-14 09:18:36 UTC) #5
mdempsky
mark: FYI, this is a reland of a previous CLs you reviewed that had to ...
6 years, 7 months ago (2014-05-14 17:09:14 UTC) #6
Mark Mentovai
6 years, 7 months ago (2014-05-14 17:29:49 UTC) #7
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698