Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: components/breakpad/app/breakpad_linux.cc

Issue 271703012: Remove SCM_CREDENTIALS fallback code from breakpad (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix kControlMsgSize Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/linux_util.cc ('k') | components/breakpad/browser/crash_handler_host_linux.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/breakpad/app/breakpad_linux.cc
diff --git a/components/breakpad/app/breakpad_linux.cc b/components/breakpad/app/breakpad_linux.cc
index dd91b86dcd1ddc65e2094ba5fc47efb935079c75..d10bc917f8881332fa69a506edea8d05ba65b4c3 100644
--- a/components/breakpad/app/breakpad_linux.cc
+++ b/components/breakpad/app/breakpad_linux.cc
@@ -797,7 +797,7 @@ class NonBrowserCrashHandler : public google_breakpad::CrashGenerationClient {
// browser to convert namespace tids.
// The length of the control message:
- static const unsigned kControlMsgSize = sizeof(fds);
+ static const unsigned kControlMsgSize = sizeof(int);
static const unsigned kControlMsgSpaceSize = CMSG_SPACE(kControlMsgSize);
static const unsigned kControlMsgLenSize = CMSG_LEN(kControlMsgSize);
@@ -837,8 +837,7 @@ class NonBrowserCrashHandler : public google_breakpad::CrashGenerationClient {
hdr->cmsg_level = SOL_SOCKET;
hdr->cmsg_type = SCM_RIGHTS;
hdr->cmsg_len = kControlMsgLenSize;
- ((int*) CMSG_DATA(hdr))[0] = fds[0];
- ((int*) CMSG_DATA(hdr))[1] = fds[1];
+ ((int*)CMSG_DATA(hdr))[0] = fds[1];
if (HANDLE_EINTR(sys_sendmsg(server_fd_, &msg, 0)) < 0) {
static const char errmsg[] = "Failed to tell parent about crash.\n";
« no previous file with comments | « base/linux_util.cc ('k') | components/breakpad/browser/crash_handler_host_linux.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698