Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2717003002:
Enable WebGL 2 by default on Android (Closed)
|
Created:
3 years, 10 months ago by Kai Ninomiya Modified:
3 years, 6 months ago CC:
chromium-reviews, piman+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionEnable WebGL 2 by default on Android
BUG=673426, 295792, 641635
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2717003002
Cr-Commit-Position: refs/heads/master@{#453293}
Committed: https://chromium.googlesource.com/chromium/src/+/52d9483cb732e314990f93bc7291927b6369c4f0
Patch Set 1 #
Messages
Total messages: 20 (13 generated)
Description was changed from ========== enable WebGL 2 on Android BUG= ========== to ========== enable WebGL 2 on Android BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== enable WebGL 2 on Android BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Enable WebGL 2 by default on Android BUG=295792,641635 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== Enable WebGL 2 by default on Android BUG=295792,641635 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Enable WebGL 2 by default on Android BUG=673426,295792,641635 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== Enable WebGL 2 by default on Android BUG=673426,295792,641635 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Enable WebGL 2 by default on Android // not ready yet COMMIT=false BUG=673426,295792,641635 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
kainino@chromium.org changed reviewers: + kbr@chromium.org, zmo@chromium.org
Preparing this ahead of time so we can land it reasonably quickly. zmo, kbr: PTAL. Is this the right way to do it?
Yes, this is the right way to enable it. There's a block of code here which handles the blacklist entry in conjunction with the about:flags entry: https://cs.chromium.org/chromium/src/content/browser/gpu/gpu_data_manager_imp... but your change here is the right way to change the default on Android. LGTM
Thanks to Kai for tenaciously working through the conformance test failures, he has gathered a 100% passing run on a second Android device. CQ'ing now so this makes the branch point.
The CQ bit was checked by kbr@chromium.org
The CQ bit was unchecked by kbr@chromium.org
Description was changed from ========== Enable WebGL 2 by default on Android // not ready yet COMMIT=false BUG=673426,295792,641635 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Enable WebGL 2 by default on Android BUG=673426,295792,641635 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by kbr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1488219566615370, "parent_rev":
"e9b9fb0998172808d880ca208685d8007b8f5a6e", "commit_rev":
"52d9483cb732e314990f93bc7291927b6369c4f0"}
Message was sent while issue was closed.
Description was changed from ========== Enable WebGL 2 by default on Android BUG=673426,295792,641635 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Enable WebGL 2 by default on Android BUG=673426,295792,641635 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2717003002 Cr-Commit-Position: refs/heads/master@{#453293} Committed: https://chromium.googlesource.com/chromium/src/+/52d9483cb732e314990f93bc7291... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/52d9483cb732e314990f93bc7291...
Message was sent while issue was closed.
head06902@gmail.com changed reviewers: + head06902@gmail.com
Message was sent while issue was closed.
head06902@gmail.com changed reviewers: + head06902@gmail.com
Message was sent while issue was closed.
Message was sent while issue was closed.
lgtm |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
