Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 2716973002: Use an in memory store until crbug.com/688533 is fixed. (Closed)

Created:
3 years, 10 months ago by skau
Modified:
3 years, 9 months ago
Reviewers:
skym
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org, pavely
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use an in memory store until crbug.com/688533 is fixed. In ChromeOS Guest Mode, Chrome runs with --disable-sync which causes ProfileSyncService to always be null. Thus, we are unable to create a ModelTypeStore. Until this can be fixed, use the in-memory store that's normally used for testing. BUG=694992 Review-Url: https://codereview.chromium.org/2716973002 Cr-Commit-Position: refs/heads/master@{#454387} Committed: https://chromium.googlesource.com/chromium/src/+/233dc1e93732142695fe2407f1ed882454cd1eab

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M chrome/browser/chromeos/printing/printers_manager_factory.cc View 1 chunk +9 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
skau
skym@: Please review. This will fix the bug for 58 so pavely@ doesn't need to ...
3 years, 9 months ago (2017-03-02 21:07:23 UTC) #2
skym
lgtm
3 years, 9 months ago (2017-03-02 21:10:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2716973002/1
3 years, 9 months ago (2017-03-02 21:16:13 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 21:48:00 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/233dc1e93732142695fe2407f1ed...

Powered by Google App Engine
This is Rietveld 408576698