Issue 271693003: Remove bad assertion in SVGSMILElement's constructQualifiedName()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 271693003: Remove bad assertion in SVGSMILElement's constructQualifiedName() (Closed)

Created:
6 years, 7 months ago by Inactive

Modified:
6 years, 7 months ago

Reviewers:
pdr., eseidel

CC:
blink-reviews, ed+blinkwatch_opera.com, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, rwlbuis, fs, kouhei+svg_chromium.org, dstockwell, Timothy Loh, krit, f(malita), gyuyoung.kim_webkit.org, darktears, Stephen Chennney, Steve Block, pdr., Eric Willigers

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove bad assertion in SVGSMILElement's constructQualifiedName() Remove bad assertion in SVGSMILElement's constructQualifiedName() by passing IGNORE_EXCEPTION instead ASSERT_NO_EXCEPTION to Document::parseQualifiedName(). The constructQualifiedName() function handles parseQualifiedName() failures propertly by returning early so there is no reason to assert on parsing failures. R=pdr@chromium.org, eseidel@chromium.org BUG=368325 TEST=svg/custom/bad-attributeName-crash.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173564

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -5 lines)			Patch
A	LayoutTests/svg/custom/bad-attributeName-crash.html	View	1 chunk	+12 lines, -0 lines	0 comments	Download
A +	LayoutTests/svg/custom/bad-attributeName-crash-expected.txt	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	Source/core/svg/animation/SVGSMILElement.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/271693003/1

6 years, 7 months ago (2014-05-07 21:50:09 UTC) #3

Message was sent while issue was closed.

Change committed as 173564

Expand Messages | Collapse Messages