Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Side by Side Diff: Source/core/svg/animation/SVGSMILElement.cpp

Issue 271693003: Remove bad assertion in SVGSMILElement's constructQualifiedName() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « LayoutTests/svg/custom/bad-attributeName-crash-expected.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 252 matching lines...) Expand 10 before | Expand all | Expand 10 after
263 static inline QualifiedName constructQualifiedName(const SVGElement* svgElement, const AtomicString& attributeName) 263 static inline QualifiedName constructQualifiedName(const SVGElement* svgElement, const AtomicString& attributeName)
264 { 264 {
265 ASSERT(svgElement); 265 ASSERT(svgElement);
266 if (attributeName.isEmpty()) 266 if (attributeName.isEmpty())
267 return anyQName(); 267 return anyQName();
268 if (!attributeName.contains(':')) 268 if (!attributeName.contains(':'))
269 return QualifiedName(nullAtom, attributeName, nullAtom); 269 return QualifiedName(nullAtom, attributeName, nullAtom);
270 270
271 AtomicString prefix; 271 AtomicString prefix;
272 AtomicString localName; 272 AtomicString localName;
273 if (!Document::parseQualifiedName(attributeName, prefix, localName, ASSERT_N O_EXCEPTION)) 273 if (!Document::parseQualifiedName(attributeName, prefix, localName, IGNORE_E XCEPTION))
274 return anyQName(); 274 return anyQName();
275 275
276 const AtomicString& namespaceURI = svgElement->lookupNamespaceURI(prefix); 276 const AtomicString& namespaceURI = svgElement->lookupNamespaceURI(prefix);
277 if (namespaceURI.isEmpty()) 277 if (namespaceURI.isEmpty())
278 return anyQName(); 278 return anyQName();
279 279
280 return QualifiedName(nullAtom, localName, namespaceURI); 280 return QualifiedName(nullAtom, localName, namespaceURI);
281 } 281 }
282 282
283 static inline void clearTimesWithDynamicOrigins(Vector<SMILTimeWithOrigin>& time List) 283 static inline void clearTimesWithDynamicOrigins(Vector<SMILTimeWithOrigin>& time List)
(...skipping 1048 matching lines...) Expand 10 before | Expand all | Expand 10 after
1332 } 1332 }
1333 } 1333 }
1334 1334
1335 void SVGSMILElement::trace(Visitor* visitor) 1335 void SVGSMILElement::trace(Visitor* visitor)
1336 { 1336 {
1337 visitor->trace(m_targetElement); 1337 visitor->trace(m_targetElement);
1338 SVGElement::trace(visitor); 1338 SVGElement::trace(visitor);
1339 } 1339 }
1340 1340
1341 } 1341 }
OLDNEW
« no previous file with comments | « LayoutTests/svg/custom/bad-attributeName-crash-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698