Adding PLM UMA for byte usage by load type

Adding PLM UMA for byte usage by load type

Comparing various load types distribution of network vs cache usage will
give insights into how much data is really being used by these load
types. This will be useful to compare to existing TabRestore UMA as
well.

BUG=695658
Review-Url: https://codereview.chromium.org/2716903002
Cr-Commit-Position: refs/heads/master@{#455229}
Committed: https://chromium.googlesource.com/chromium/src/+/d02a1d189e60d72da5511ec2620a1ff89d642cf8

[RyanSturm, 2017-02-24 18:39:48]

The CQ bit was checked by ryansturm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 18:40:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 19:10:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 19:10:34]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[RyanSturm, 2017-02-24 19:54:29]

The CQ bit was checked by ryansturm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 19:55:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 21:34:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 21:34:10]

Dry run: This issue passed the CQ dry run.

[RyanSturm, 2017-02-25 01:10:32]

ryansturm@chromium.org changed reviewers:
+ bengr@chromium.org, bmcquade@chromium.org

[RyanSturm, 2017-02-25 01:10:32]

bmcquade: PTAL, thanks

bengr: PTAL, let me know if there is anything else you want related to this.

[Bryan McQuade, 2017-03-01 02:17:01]

LGTM, thanks!

[bengr, 2017-03-01 20:54:13]

lgtm

https://codereview.chromium.org/2716903002/diff/1/chrome/browser/page_load_me...
File
chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
(right):

https://codereview.chromium.org/2716903002/diff/1/chrome/browser/page_load_me...
chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc:752:
switch (GetPageLoadType(transition_)) {
Are there any other transitions of interest? Ideally, e.g., a transition to load
an original page after a preview should be a transition type. Consider adding a
TODO with a crbug for previews.

[RyanSturm, 2017-03-02 01:18:49]

I think for right now, these are the most interesting transition types.
Certainly, there are some other interesting aspects of transitions that we could
look into. The only semi-interesting transitions to me are bookmark or home
page, but I don't think they are incredibly interesting right now.

[RyanSturm, 2017-03-02 01:18:56]

The CQ bit was checked by ryansturm@chromium.org

[commit-bot: I haz the power, 2017-03-02 01:19:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 01:33:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 01:33:51]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[RyanSturm, 2017-03-02 01:58:38]

ryansturm@chromium.org changed reviewers:
+ asvitkine@chromium.org

[RyanSturm, 2017-03-02 01:58:38]

Asvitkine: ptal, thanks

[Alexei Svitkine (slow), 2017-03-06 22:06:08]

lgtm

https://codereview.chromium.org/2716903002/diff/1/chrome/browser/page_load_me...
File
chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
(right):

https://codereview.chromium.org/2716903002/diff/1/chrome/browser/page_load_me...
chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc:415:
for (auto request : resources) {
Nit: const auto&

https://codereview.chromium.org/2716903002/diff/1/chrome/browser/page_load_me...
chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc:500:
for (auto request : resources) {
Nit: const auto&

[RyanSturm, 2017-03-07 00:22:52]

The CQ bit was checked by ryansturm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-07 00:23:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 02:18:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 02:18:52]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[RyanSturm, 2017-03-07 02:42:29]

The CQ bit was checked by ryansturm@chromium.org

[RyanSturm, 2017-03-07 02:42:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
bmcquade@chromium.org, bengr@chromium.org, asvitkine@chromium.org
Link to the patchset: https://codereview.chromium.org/2716903002/#ps20001
(title: "asvitkine nits")

[commit-bot: I haz the power, 2017-03-07 02:43:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 06:21:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 06:21:43]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[RyanSturm, 2017-03-07 20:27:36]

The CQ bit was checked by ryansturm@chromium.org

[commit-bot: I haz the power, 2017-03-07 20:28:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 21:48:51]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488918456831190,
"parent_rev": "ad53642b18c11cfcfd5424ef18a5ba40637ae635", "commit_rev":
"d02a1d189e60d72da5511ec2620a1ff89d642cf8"}

[commit-bot: I haz the power, 2017-03-07 21:49:33]

Description was changed from

==========
Adding PLM UMA for byte usage by load type

Comparing various load types distribution of network vs cache usage will
give insights into how much data is really being used by these load
types. This will be useful to compare to existing TabRestore UMA as
well.

BUG=695658
==========

to

==========
Adding PLM UMA for byte usage by load type

Comparing various load types distribution of network vs cache usage will
give insights into how much data is really being used by these load
types. This will be useful to compare to existing TabRestore UMA as
well.

BUG=695658

Review-Url: https://codereview.chromium.org/2716903002
Cr-Commit-Position: refs/heads/master@{#455229}
Committed:
https://chromium.googlesource.com/chromium/src/+/d02a1d189e60d72da5511ec2620a...
==========

[commit-bot: I haz the power, 2017-03-07 21:49:34]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d02a1d189e60d72da5511ec2620a...