Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2716873003: Replaces media::StrongBindingSet with mojo::StrongBindingSet. (Closed)

Created:
3 years, 10 months ago by alokp
Modified:
3 years, 9 months ago
Reviewers:
xhwang
CC:
chromium-reviews, feature-media-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, alokp+watch_chromium.org, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replaces media::StrongBindingSet with mojo::StrongBindingSet. BUG=604912 Review-Url: https://codereview.chromium.org/2716873003 Cr-Commit-Position: refs/heads/master@{#453362} Committed: https://chromium.googlesource.com/chromium/src/+/647234812da3104a6d8ae2d87a24ae8969191b6b

Patch Set 1 #

Patch Set 2 : fixes build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -216 lines) Patch
M media/mojo/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M media/mojo/services/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M media/mojo/services/interface_factory_impl.h View 2 chunks +5 lines, -5 lines 0 comments Download
M media/mojo/services/interface_factory_impl.cc View 1 1 chunk +6 lines, -6 lines 0 comments Download
D media/mojo/services/strong_binding_set.h View 1 chunk +0 lines, -97 lines 0 comments Download
D media/mojo/services/strong_binding_set_unittest.cc View 1 chunk +0 lines, -106 lines 0 comments Download

Messages

Total messages: 24 (16 generated)
alokp
3 years, 10 months ago (2017-02-25 00:27:04 UTC) #6
xhwang
Thanks for doing this! LGTM
3 years, 9 months ago (2017-02-27 17:09:24 UTC) #11
xhwang
BTW, you can use https://bugs.chromium.org/p/chromium/issues/detail?id=604912 in BUG for easy tracking in the future.
3 years, 9 months ago (2017-02-27 17:11:41 UTC) #12
alokp
On 2017/02/27 17:11:41, xhwang_slow wrote: > BTW, you can use https://bugs.chromium.org/p/chromium/issues/detail?id=604912 in > BUG for ...
3 years, 9 months ago (2017-02-27 17:47:06 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2716873003/1
3 years, 9 months ago (2017-02-27 17:47:46 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/317229)
3 years, 9 months ago (2017-02-27 18:05:59 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2716873003/20001
3 years, 9 months ago (2017-02-27 20:18:11 UTC) #21
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 22:40:09 UTC) #24
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/647234812da3104a6d8ae2d87a24...

Powered by Google App Engine
This is Rietveld 408576698