Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 271683004: Expose default ctor of SQS and remove Create and Copy funciton of SQS (Closed)

Created:
6 years, 7 months ago by weiliangc
Modified:
6 years, 7 months ago
Reviewers:
danakj
CC:
chromium-reviews, cc-bugs_chromium.org, Ian Vollick, enne (OOO)
Base URL:
https://chromium.googlesource.com/chromium/src.git@RPPower
Visibility:
Public.

Description

Expose default ctor of SQS and remove Create and Copy funciton of SQS In order to avoid passing around ownership of SQS, expose default ctor, and remove all function that returns scoped_ptr of SQS, meaning Create and Copy function. Alternative of Copy function is CopyFrom function that is called on raw pointer. This follows 265823015 and 271703003. BUG=344962 TEST=cc_unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269901

Patch Set 1 #

Total comments: 4

Patch Set 2 : rebase #

Patch Set 3 : Address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -21 lines) Patch
M cc/quads/draw_quad_unittest.cc View 1 2 4 chunks +8 lines, -6 lines 0 comments Download
M cc/quads/render_pass.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M cc/quads/shared_quad_state.h View 2 chunks +1 line, -5 lines 0 comments Download
M cc/quads/shared_quad_state.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
weiliangc
6 years, 7 months ago (2014-05-08 14:44:44 UTC) #1
danakj
LGTM https://codereview.chromium.org/271683004/diff/1/cc/quads/draw_quad_unittest.cc File cc/quads/draw_quad_unittest.cc (right): https://codereview.chromium.org/271683004/diff/1/cc/quads/draw_quad_unittest.cc#newcode42 cc/quads/draw_quad_unittest.cc:42: scoped_ptr<SharedQuadState> state = make_scoped_ptr(new SharedQuadState()); btw this also ...
6 years, 7 months ago (2014-05-08 16:51:41 UTC) #2
weiliangc
Updated addressing review comments and rebase. https://codereview.chromium.org/271683004/diff/1/cc/quads/draw_quad_unittest.cc File cc/quads/draw_quad_unittest.cc (right): https://codereview.chromium.org/271683004/diff/1/cc/quads/draw_quad_unittest.cc#newcode42 cc/quads/draw_quad_unittest.cc:42: scoped_ptr<SharedQuadState> state = ...
6 years, 7 months ago (2014-05-12 21:54:53 UTC) #3
weiliangc
The CQ bit was checked by weiliangc@chromium.org
6 years, 7 months ago (2014-05-12 22:12:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/weiliangc@chromium.org/271683004/40001
6 years, 7 months ago (2014-05-12 22:13:04 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-12 22:50:52 UTC) #6
Message was sent while issue was closed.
Change committed as 269901

Powered by Google App Engine
This is Rietveld 408576698