cc/quads/shared_quad_state.h - Issue 271683004: Expose default ctor of SQS and remove Create and Copy funciton of SQS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/quads/shared_quad_state.h

Issue 271683004: Expose default ctor of SQS and remove Create and Copy funciton of SQS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@RPPower

Patch Set: Address review comments Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/quads/shared_quad_state.h

diff --git a/cc/quads/shared_quad_state.h b/cc/quads/shared_quad_state.h

index cf4438158ec57eceb3115a201c8e995dd3aaa53b..d0e2afb64ef572c6c493844078400d217ccd3a47 100644

--- a/cc/quads/shared_quad_state.h

+++ b/cc/quads/shared_quad_state.h

@@ -24,10 +24,9 @@ namespace cc {

// QuadList.

class CC_EXPORT SharedQuadState {

public:

- static scoped_ptr<SharedQuadState> Create();

+ SharedQuadState();

~SharedQuadState();

- scoped_ptr<SharedQuadState> Copy() const;

void CopyFrom(const SharedQuadState* other);

void SetAll(const gfx::Transform& content_to_target_transform,

@@ -50,9 +49,6 @@ class CC_EXPORT SharedQuadState {

bool is_clipped;

float opacity;

SkXfermode::Mode blend_mode;

- private:

- SharedQuadState();

};

} // namespace cc

« no previous file with comments | « cc/quads/render_pass.cc ('k') | cc/quads/shared_quad_state.cc » ('j') | no next file with comments »