Remove inheritance on SameSizeAsComputedStyle.

Remove inheritance on SameSizeAsComputedStyle.

Currently there is a static assert that checks the size of ComputedStyle
against a comparison struct of known size. However, the comparison
struct inherits from ComputedStyleBase, so the size of ComputedStyleBase
is hidden from view. This patch explicitly declares the size of
ComputedStyleBase in the comparison struct so that we can get a better
sense of how big ComputedStyle is.

BUG=628043
Review-Url: https://codereview.chromium.org/2716813002
Cr-Commit-Position: refs/heads/master@{#453345}
Committed: https://chromium.googlesource.com/chromium/src/+/92131be1f24ca5fa037afb835c4df358269a113c

[shend, 2017-02-24 05:22:55]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 05:23:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[shend, 2017-02-24 06:01:11]

shend@chromium.org changed reviewers:
+ sashab@chromium.org

[shend, 2017-02-24 06:01:12]

Hi Sasha, PTAL

[sashab, 2017-02-24 06:05:40]

sashab@chromium.org changed reviewers:
+ esprehn@chromium.org

[sashab, 2017-02-24 06:05:41]

I'm really happy about this, so LGTM. But lets see if esprehn@ has any ideas
before we land it.

https://codereview.chromium.org/2716813002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/style/ComputedStyle.cpp (right):

https://codereview.chromium.org/2716813002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/style/ComputedStyle.cpp:92: // update the
SameSizeAsComputedStyle struct to mirror the updated storage of
Check that you really *do* want to increase the size of ComputedStyle, then
update...

[commit-bot: I haz the power, 2017-02-24 06:41:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 06:41:03]

Dry run: This issue passed the CQ dry run.

[esprehn, 2017-02-24 17:59:49]

lgtm, Inheritance in these size checks is useful for something global, ex.
RefCounted since that should be size checked elsewhere, but for something like
the code generated base class this looks like a great way to understand how much
space we're actually using.

https://codereview.chromium.org/2716813002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/style/ComputedStyle.cpp (right):

https://codereview.chromium.org/2716813002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/style/ComputedStyle.cpp:92: // update the
SameSizeAsComputedStyle struct to mirror the updated storage of
On 2017/02/24 at 06:05:41, sashab wrote:
> Check that you really *do* want to increase the size of ComputedStyle, then
update...

Word.

[shend, 2017-02-27 19:36:44]

https://codereview.chromium.org/2716813002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/style/ComputedStyle.cpp (right):

https://codereview.chromium.org/2716813002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/style/ComputedStyle.cpp:92: // update the
SameSizeAsComputedStyle struct to mirror the updated storage of
On 2017/02/24 at 17:59:48, esprehn wrote:
> On 2017/02/24 at 06:05:41, sashab wrote:
> > Check that you really *do* want to increase the size of ComputedStyle, then
update...
> 
> Word.

Done.

[shend, 2017-02-27 19:36:49]

The CQ bit was checked by shend@chromium.org

[shend, 2017-02-27 19:36:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
esprehn@chromium.org, sashab@chromium.org
Link to the patchset: https://codereview.chromium.org/2716813002/#ps40001
(title: "Change comments")

[commit-bot: I haz the power, 2017-02-27 19:37:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 21:34:59]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488224209999320,
"parent_rev": "908248cbb5439c9a2ca5150688d641982857000a", "commit_rev":
"92131be1f24ca5fa037afb835c4df358269a113c"}

[commit-bot: I haz the power, 2017-02-27 21:35:42]

Description was changed from

==========
Remove inheritance on SameSizeAsComputedStyle.

Currently there is a static assert that checks the size of ComputedStyle
against a comparison struct of known size. However, the comparison
struct inherits from ComputedStyleBase, so the size of ComputedStyleBase
is hidden from view. This patch explicitly declares the size of
ComputedStyleBase in the comparison struct so that we can get a better
sense of how big ComputedStyle is.

BUG=628043
==========

to

==========
Remove inheritance on SameSizeAsComputedStyle.

Currently there is a static assert that checks the size of ComputedStyle
against a comparison struct of known size. However, the comparison
struct inherits from ComputedStyleBase, so the size of ComputedStyleBase
is hidden from view. This patch explicitly declares the size of
ComputedStyleBase in the comparison struct so that we can get a better
sense of how big ComputedStyle is.

BUG=628043

Review-Url: https://codereview.chromium.org/2716813002
Cr-Commit-Position: refs/heads/master@{#453345}
Committed:
https://chromium.googlesource.com/chromium/src/+/92131be1f24ca5fa037afb835c4d...
==========

[commit-bot: I haz the power, 2017-02-27 21:35:42]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/92131be1f24ca5fa037afb835c4d...