Simplify TextControlElementTest.SetSelectionRangeDoesNotCaluseLayout

Simplify TextControlElementTest.SetSelectionRangeDoesNotCaluseLayout

It doesn't make sense that forceLayoutFlag doesn't force layout.
Then this CL refine the test that
TextControlElement::setSelectionRange doesn't call layout in appropriate 
condition. 

BUG=692537
Review-Url: https://codereview.chromium.org/2716793002
Cr-Commit-Position: refs/heads/master@{#454186}
Committed: https://chromium.googlesource.com/chromium/src/+/b6b46d096a709930f22c2265b3378930dcf579c3

[yoichio, 2017-02-24 04:35:32]

The CQ bit was checked by yoichio@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 04:35:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 05:48:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 05:48:57]

Dry run: This issue passed the CQ dry run.

[yoichio, 2017-02-24 06:54:26]

Description was changed from

==========
Update  TextControlElementTest, SetSelectionRangeDoesNotCauseLayout

BUG=
==========

to

==========
Refine SetSelectionRangeDoesNotCauseLayout

It doesn't make sense that forceLayoutFlag doesn't force layout.
Then this CL refine the test that
TextControlElement::setSelectionRange doesn't call layout in appropriate 
condition. 

BUG=692537
==========

[yoichio, 2017-02-24 06:54:26]

yoichio@chromium.org changed reviewers:
+ yosin@chromium.org

[yoichio, 2017-02-24 07:05:10]

The CQ bit was checked by yoichio@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 07:05:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-02-24 07:36:36]

https://codereview.chromium.org/2716793002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/TextControlElementTest.cpp (right):

https://codereview.chromium.org/2716793002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/TextControlElementTest.cpp:75:
DocumentLifecycle::DisallowTransitionScope disallowTransition(
DocumentLifecycle::DisallowTransitionScope does nothing for DHCECK_IS_ON() is
false.

Could you check layout count?

[commit-bot: I haz the power, 2017-02-24 07:36:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 07:36:42]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[yoichio, 2017-02-28 02:11:39]

https://codereview.chromium.org/2716793002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/TextControlElementTest.cpp (right):

https://codereview.chromium.org/2716793002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/TextControlElementTest.cpp:75:
DocumentLifecycle::DisallowTransitionScope disallowTransition(
On 2017/02/24 07:36:36, yosin_UTC9 wrote:
> DocumentLifecycle::DisallowTransitionScope does nothing for DHCECK_IS_ON() is
> false.
What do you mean? This test is built as both debug/release.

[yosin_UTC9, 2017-02-28 02:23:06]

https://codereview.chromium.org/2716793002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/TextControlElementTest.cpp (right):

https://codereview.chromium.org/2716793002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/TextControlElementTest.cpp:75:
DocumentLifecycle::DisallowTransitionScope disallowTransition(
On 2017/02/28 at 02:11:39, yoichio wrote:
> On 2017/02/24 07:36:36, yosin_UTC9 wrote:
> > DocumentLifecycle::DisallowTransitionScope does nothing for DHCECK_IS_ON()
is
> > false.
> What do you mean? This test is built as both debug/release.

I mean rather than detecting test failure by DCHECK(), we can use EXPECT_EQ()
with layout count.

[yoichio, 2017-02-28 03:44:37]

The CQ bit was checked by yoichio@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 03:45:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yoichio, 2017-02-28 04:11:56]

https://codereview.chromium.org/2716793002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/TextControlElementTest.cpp (right):

https://codereview.chromium.org/2716793002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/TextControlElementTest.cpp:75:
DocumentLifecycle::DisallowTransitionScope disallowTransition(
On 2017/02/28 02:23:05, yosin_UTC9 wrote:
> On 2017/02/28 at 02:11:39, yoichio wrote:
> > On 2017/02/24 07:36:36, yosin_UTC9 wrote:
> > > DocumentLifecycle::DisallowTransitionScope does nothing for DHCECK_IS_ON()
> is
> > > false.
> > What do you mean? This test is built as both debug/release.
> 
> I mean rather than detecting test failure by DCHECK(), we can use EXPECT_EQ()
> with layout count.

Done.

[commit-bot: I haz the power, 2017-02-28 05:12:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 05:12:53]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2017-02-28 07:24:56]

lgtm

I recommend to use more detailed summary or changes in TextControlElementTest,
e.g.
Simplify TextControlElementTest.SetSelectionRangeDoesNotCaluseLayout

[yoichio, 2017-02-28 10:33:17]

Description was changed from

==========
Refine SetSelectionRangeDoesNotCauseLayout

It doesn't make sense that forceLayoutFlag doesn't force layout.
Then this CL refine the test that
TextControlElement::setSelectionRange doesn't call layout in appropriate 
condition. 

BUG=692537
==========

to

==========
Simplify TextControlElementTest.SetSelectionRangeDoesNotCaluseLayout

It doesn't make sense that forceLayoutFlag doesn't force layout.
Then this CL refine the test that
TextControlElement::setSelectionRange doesn't call layout in appropriate 
condition. 

BUG=692537
==========

[yoichio, 2017-02-28 10:33:47]

The CQ bit was checked by yoichio@chromium.org

[commit-bot: I haz the power, 2017-02-28 10:33:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 10:41:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 10:41:46]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[yoichio, 2017-03-01 08:43:06]

yoichio@chromium.org changed reviewers:
+ tkent@chromium.org

[yoichio, 2017-03-01 08:43:07]

Kent, could you take an OWNER look ?

[tkent, 2017-03-01 08:45:21]

lgtm

[yoichio, 2017-03-02 04:40:38]

The CQ bit was checked by yoichio@chromium.org

[commit-bot: I haz the power, 2017-03-02 04:41:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 05:38:42]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488429638566510,
"parent_rev": "7e20e35dace024a8291ed7cd88e23b827c5f55e1", "commit_rev":
"b6b46d096a709930f22c2265b3378930dcf579c3"}

[commit-bot: I haz the power, 2017-03-02 05:39:42]

Description was changed from

==========
Simplify TextControlElementTest.SetSelectionRangeDoesNotCaluseLayout

It doesn't make sense that forceLayoutFlag doesn't force layout.
Then this CL refine the test that
TextControlElement::setSelectionRange doesn't call layout in appropriate 
condition. 

BUG=692537
==========

to

==========
Simplify TextControlElementTest.SetSelectionRangeDoesNotCaluseLayout

It doesn't make sense that forceLayoutFlag doesn't force layout.
Then this CL refine the test that
TextControlElement::setSelectionRange doesn't call layout in appropriate 
condition. 

BUG=692537

Review-Url: https://codereview.chromium.org/2716793002
Cr-Commit-Position: refs/heads/master@{#454186}
Committed:
https://chromium.googlesource.com/chromium/src/+/b6b46d096a709930f22c2265b337...
==========

[commit-bot: I haz the power, 2017-03-02 05:39:43]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/b6b46d096a709930f22c2265b337...