Enforce two-day limit on lease requests

Enforce two-day limit on lease requests

BUG=692407
Review-Url: https://codereview.chromium.org/2716783002
Committed: https://github.com/luci/luci-py/commit/c85f474a910c5bc1185fc404dc570cad18ab0ee0

[smut, 2017-02-24 03:04:21]

smut@google.com changed reviewers:
+ vadimsh@chromium.org

[smut, 2017-02-24 03:04:21]

The longest we lease for right now is 24 hours. Enforce a limit of 48. Arbitrary
limit (like the 10 instance template limit enforced in GCE Backend) that we can
increase if necessary.

[Vadim Sh., 2017-02-24 03:09:09]

vadimsh@chromium.org changed reviewers:
+ estaab@chromium.org

[Vadim Sh., 2017-02-24 03:09:09]

lgtm, but I remember Erik wanted to have long leases for Chromium Tryserver LUCI
builders (to reduce impact of a cold cache problem).

[smut, 2017-02-24 03:15:37]

On 2017/02/24 03:09:09, Vadim Sh. wrote:
> lgtm, but I remember Erik wanted to have long leases for Chromium Tryserver
LUCI
> builders (to reduce impact of a cold cache problem).

I don't want long-lived leases to be the solution, because then we're losing the
advantages of short-lived VMs. I'd prefer some other solution like
pre-populating the cache on new VM startup or attaching a long-lived disk that
contains the necessary caches or whatever.

At any rate, whatever we do seems far off. We can easily increase this as
needed.

[estaab, 2017-02-24 03:25:57]

On 2017/02/24 at 03:15:37, smut wrote:
> On 2017/02/24 03:09:09, Vadim Sh. wrote:
> > lgtm, but I remember Erik wanted to have long leases for Chromium Tryserver
LUCI
> > builders (to reduce impact of a cold cache problem).
> 
> I don't want long-lived leases to be the solution, because then we're losing
the advantages of short-lived VMs. I'd prefer some other solution like
pre-populating the cache on new VM startup or attaching a long-lived disk that
contains the necessary caches or whatever.
> 
> At any rate, whatever we do seems far off. We can easily increase this as
needed.

Seems fine to do this since we just won't use MP for builders on swarming.

Everyone wants a solution that solves our build affinity problems but I haven't
seen anything to suggest we can solve them without quarters of work from
multiple engineers, and even then without a guarantee of success. We may need to
take a more practical route if managing non-MP bots on swarming ends of being
too costly. That said, I'd prefer frequent short leases with extension requests
rather than long initial leases so we have the freedom to reject extensions when
we need to deploy new images urgently.

[smut, 2017-02-24 23:16:02]

The CQ bit was checked by smut@google.com

[commit-bot: I haz the power, 2017-02-24 23:16:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 23:19:01]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487978162499400, "parent_rev":
"f6ca3fe540770a752af0529de8723efdee4085e0", "commit_rev":
"c85f474a910c5bc1185fc404dc570cad18ab0ee0"}

[commit-bot: I haz the power, 2017-02-24 23:19:04]

Description was changed from

==========
Enforce two-day limit on lease requests

BUG=692407
==========

to

==========
Enforce two-day limit on lease requests

BUG=692407

Review-Url: https://codereview.chromium.org/2716783002
Committed:
https://github.com/luci/luci-py/commit/c85f474a910c5bc1185fc404dc570cad18ab0ee0
==========

[commit-bot: I haz the power, 2017-02-24 23:19:05]

Committed patchset #1 (id:1) as
https://github.com/luci/luci-py/commit/c85f474a910c5bc1185fc404dc570cad18ab0ee0