Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2716773003: Revert "Revert of [tab_grid] Hack-in border for active tab. (patchset #5 id:80001 of https://codere… (Closed)

Created:
3 years, 9 months ago by edchin
Modified:
3 years, 9 months ago
CC:
chromium-reviews, marq+scrutinize_chromium.org, lpromero+watch_chromium.org, marq+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Revert of [tab_grid] Hack-in border for active tab. (patchset #5 id:80001 of https://codereview.chromium.org/2709563002/ )" This reverts commit 08c967e83d04e01d125b34698baa891f9882be03. The cell selection and reload logic was incorrect. If the same cell was selected again, two identical indexPaths were passed into -reloadItemsAtIndexPath:. BUG=686770 Review-Url: https://codereview.chromium.org/2716773003 Cr-Commit-Position: refs/heads/master@{#453250} Committed: https://chromium.googlesource.com/chromium/src/+/7b9838e8d245af689d35101e3ed3d64c03931e3a

Patch Set 1 : Original CL #

Patch Set 2 : Fix cell refresh logic. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -37 lines) Patch
M ios/clean/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/clean/chrome/browser/ui/tab_grid/tab_grid_tab_cell.h View 1 chunk +6 lines, -5 lines 0 comments Download
M ios/clean/chrome/browser/ui/tab_grid/tab_grid_tab_cell.mm View 1 chunk +8 lines, -24 lines 0 comments Download
M ios/clean/chrome/browser/ui/tab_grid/tab_grid_view_controller.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ios/clean/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm View 1 6 chunks +31 lines, -8 lines 0 comments Download
M ios/showcase/tab_grid/sc_tab_grid_coordinator.mm View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
edchin
3 years, 9 months ago (2017-02-26 07:28:29 UTC) #8
jif
lgtm
3 years, 9 months ago (2017-02-27 10:36:00 UTC) #9
marq (ping after 24h)
lgtm
3 years, 9 months ago (2017-02-27 16:36:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2716773003/20001
3 years, 9 months ago (2017-02-27 17:38:57 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 17:55:22 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7b9838e8d245af689d35101e3ed3...

Powered by Google App Engine
This is Rietveld 408576698