Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 2716733006: SerializedScriptValue: Remove the 16-bit string representation. (Closed)

Created:
3 years, 10 months ago by jbroman
Modified:
3 years, 10 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews, jbroman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

SerializedScriptValue: Remove the 16-bit string representation. This was used by the legacy serializer, but the new one only produces the representation backed by a PartitionAlloc buffer. Make the only other path use it as well, and simplify the code. BUG=690132 Review-Url: https://codereview.chromium.org/2716733006 Cr-Commit-Position: refs/heads/master@{#453088} Committed: https://chromium.googlesource.com/chromium/src/+/af8599b05922a8f2b945afe6b7d8468ed3565130

Patch Set 1 #

Patch Set 2 : simplify by using String::copyTo, which will never do a StringImpl allocation #

Patch Set 3 : remove a comment #

Patch Set 4 : SSV::data can now be const #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -66 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.h View 1 2 3 3 chunks +2 lines, -35 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.cpp View 1 3 chunks +17 lines, -31 lines 0 comments Download

Messages

Total messages: 18 (14 generated)
jbroman
3 years, 10 months ago (2017-02-25 06:15:23 UTC) #12
haraken
LGTM
3 years, 10 months ago (2017-02-25 09:20:50 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2716733006/60001
3 years, 10 months ago (2017-02-25 13:34:25 UTC) #15
commit-bot: I haz the power
3 years, 10 months ago (2017-02-25 13:43:46 UTC) #18
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/af8599b05922a8f2b945afe6b7d8...

Powered by Google App Engine
This is Rietveld 408576698