Oilpan: move DOMImplementation to the heap.

Oilpan: move DOMImplementation to the heap.

R=tkent@chromium.org,haraken@chromium.org
BUG=340522
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173611

[sof, 2014-05-07 16:07:30]

Please take a look.

[tkent, 2014-05-07 23:43:20]

https://codereview.chromium.org/271673005/diff/1/Source/core/dom/DOMImplement...
File Source/core/dom/DOMImplementation.cpp (right):

https://codereview.chromium.org/271673005/diff/1/Source/core/dom/DOMImplement...
Source/core/dom/DOMImplementation.cpp:204: DocumentInit init =
DocumentInit::fromContext(m_document->contextDocument());
Please use document() instead of m_document.

https://codereview.chromium.org/271673005/diff/1/Source/core/dom/DOMImplement...
File Source/core/dom/DOMImplementation.h (right):

https://codereview.chromium.org/271673005/diff/1/Source/core/dom/DOMImplement...
Source/core/dom/DOMImplementation.h:46: static
PassOwnPtrWillBeRawPtr<DOMImplementation> create(Document* document)
Why do you change the argument type from a reference to a pointer?

[haraken, 2014-05-08 00:54:50]

LGTM with tkent-san's comments.

[sof, 2014-05-08 05:24:13]

https://codereview.chromium.org/271673005/diff/1/Source/core/dom/DOMImplement...
File Source/core/dom/DOMImplementation.h (right):

https://codereview.chromium.org/271673005/diff/1/Source/core/dom/DOMImplement...
Source/core/dom/DOMImplementation.h:46: static
PassOwnPtrWillBeRawPtr<DOMImplementation> create(Document* document)
On 2014/05/07 23:43:20, tkent wrote:
> Why do you change the argument type from a reference to a pointer?

At the single call site, converting a pointer into a reference, only to convert
it back into a pointer (Member) is making work for questionable gain. Are there
some to be had?

[tkent, 2014-05-08 06:09:15]

https://codereview.chromium.org/271673005/diff/1/Source/core/dom/DOMImplement...
File Source/core/dom/DOMImplementation.h (right):

https://codereview.chromium.org/271673005/diff/1/Source/core/dom/DOMImplement...
Source/core/dom/DOMImplementation.h:46: static
PassOwnPtrWillBeRawPtr<DOMImplementation> create(Document* document)
On 2014/05/08 05:24:13, sof wrote:
> On 2014/05/07 23:43:20, tkent wrote:
> > Why do you change the argument type from a reference to a pointer?
> 
> At the single call site, converting a pointer into a reference, only to
convert
> it back into a pointer (Member) is making work for questionable gain. Are
there
> some to be had?

Even in such case, the reference still has benefit as ever. It tells us that the
variable can't be null without any words.

[sof, 2014-05-08 06:14:52]

https://codereview.chromium.org/271673005/diff/1/Source/core/dom/DOMImplement...
File Source/core/dom/DOMImplementation.h (right):

https://codereview.chromium.org/271673005/diff/1/Source/core/dom/DOMImplement...
Source/core/dom/DOMImplementation.h:46: static
PassOwnPtrWillBeRawPtr<DOMImplementation> create(Document* document)
On 2014/05/08 06:09:16, tkent wrote:
> On 2014/05/08 05:24:13, sof wrote:
> > On 2014/05/07 23:43:20, tkent wrote:
> > > Why do you change the argument type from a reference to a pointer?
> > 
> > At the single call site, converting a pointer into a reference, only to
> convert
> > it back into a pointer (Member) is making work for questionable gain. Are
> there
> > some to be had?
> 
> Even in such case, the reference still has benefit as ever. It tells us that
the
> variable can't be null without any words.
> 

I'll switch back, but the lack of reviewing consistency is sub-optimal. i.e.,
asked in other ongoing dom/ reviews to switch away from refs in create()
signatures.

[sof, 2014-05-08 06:22:24]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2014-05-08 06:22:54]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sigbjornf@opera.com/271673005/20001

[Mads Ager (chromium), 2014-05-08 07:31:11]

LGTM

https://codereview.chromium.org/271673005/diff/20001/Source/core/dom/DOMImple...
File Source/core/dom/DOMImplementation.h (right):

https://codereview.chromium.org/271673005/diff/20001/Source/core/dom/DOMImple...
Source/core/dom/DOMImplementation.h:55: Document& document() const { return
*m_document.get(); }
You can remove the .get() call here. Both RawPtr<T> and Member<T> have an
operator* of the form:

T& operator*() const { return *m_raw; }

[commit-bot: I haz the power, 2014-05-08 07:46:37]

Change committed as 173611