Source/core/dom/DOMImplementation.cpp - Issue 271673005: Oilpan: move DOMImplementation to the heap.

Unified Diff: Source/core/dom/DOMImplementation.cpp

Issue 271673005: Oilpan: move DOMImplementation to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Adjust signature Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/DOMImplementation.cpp

diff --git a/Source/core/dom/DOMImplementation.cpp b/Source/core/dom/DOMImplementation.cpp

index 8b5297e622bd7a350885fccd2d091b75360ee886..aaf449b38314acec02f27ba97a7da8265cb029f2 100644

--- a/Source/core/dom/DOMImplementation.cpp

+++ b/Source/core/dom/DOMImplementation.cpp

@@ -194,24 +194,24 @@ PassRefPtr<DocumentType> DOMImplementation::createDocumentType(const AtomicStrin

if (!Document::parseQualifiedName(qualifiedName, prefix, localName, exceptionState))

return nullptr;

- return DocumentType::create(&m_document, qualifiedName, publicId, systemId);

+ return DocumentType::create(m_document, qualifiedName, publicId, systemId);

}

PassRefPtr<XMLDocument> DOMImplementation::createDocument(const AtomicString& namespaceURI,

const AtomicString& qualifiedName, DocumentType* doctype, ExceptionState& exceptionState)

{

RefPtr<XMLDocument> doc;

- DocumentInit init = DocumentInit::fromContext(m_document.contextDocument());

+ DocumentInit init = DocumentInit::fromContext(document().contextDocument());

if (namespaceURI == SVGNames::svgNamespaceURI) {

doc = XMLDocument::createSVG(init);

} else if (namespaceURI == HTMLNames::xhtmlNamespaceURI) {

- doc = XMLDocument::createXHTML(init.withRegistrationContext(m_document.registrationContext()));

+ doc = XMLDocument::createXHTML(init.withRegistrationContext(document().registrationContext()));

} else {

doc = XMLDocument::create(init);

}

- doc->setSecurityOrigin(m_document.securityOrigin()->isolatedCopy());

- doc->setContextFeatures(m_document.contextFeatures());

+ doc->setSecurityOrigin(document().securityOrigin()->isolatedCopy());

+ doc->setContextFeatures(document().contextFeatures());

RefPtr<Node> documentElement;

if (!qualifiedName.isEmpty()) {

@@ -320,15 +320,15 @@ bool DOMImplementation::isTextMIMEType(const String& mimeType)

PassRefPtr<HTMLDocument> DOMImplementation::createHTMLDocument(const String& title)

{

- DocumentInit init = DocumentInit::fromContext(m_document.contextDocument())

- .withRegistrationContext(m_document.registrationContext());

+ DocumentInit init = DocumentInit::fromContext(document().contextDocument())

+ .withRegistrationContext(document().registrationContext());

RefPtr<HTMLDocument> d = HTMLDocument::create(init);

d->open();

d->write("<!doctype html><html><body></body></html>");

if (!title.isNull())

d->setTitle(title);

- d->setSecurityOrigin(m_document.securityOrigin()->isolatedCopy());

- d->setContextFeatures(m_document.contextFeatures());

+ d->setSecurityOrigin(document().securityOrigin()->isolatedCopy());

+ d->setContextFeatures(document().contextFeatures());

return d.release();

}

@@ -378,4 +378,9 @@ PassRefPtr<Document> DOMImplementation::createDocument(const String& type, const

return HTMLDocument::create(init);

}

+void DOMImplementation::trace(Visitor* visitor)

+ visitor->trace(m_document);

}

« Source/core/dom/DOMImplementation.h ('K') | « Source/core/dom/DOMImplementation.h ('k') | Source/core/dom/DOMImplementation.idl » ('j') | no next file with comments »