Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Issue 2716713004: Verify FormsTestCase forms submission result. (Closed)

Created:
3 years, 10 months ago by michaeldo
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Verify FormsTestCase forms submission result. Add a missing GREYAssert to the |waitWithTimeout:| calls in |waitForExpectedResponse:| and |waitForTabHistoryView|. Fix silently failing tests (due to previously missing asserts) by implementing /printformdata page to display the request method and body. BUG=685439 Review-Url: https://codereview.chromium.org/2690853008 Cr-Commit-Position: refs/heads/master@{#450717} (cherry picked from commit 59a7ad896fbc906833b38120fc8776a368fe28d2) Review-Url: https://codereview.chromium.org/2716713004 . Cr-Commit-Position: refs/branch-heads/2987@{#684} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/f8f03da2948620b7b3b946b5abd637e38734586b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -58 lines) Patch
M ios/chrome/browser/web/forms_egtest.mm View 12 chunks +108 lines, -58 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
michaeldo
3 years, 10 months ago (2017-02-24 23:05:18 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f8f03da2948620b7b3b946b5abd637e38734586b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698