Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 2716693002: Allow inline install for user initiated fullscreen mode (Closed)

Created:
3 years, 10 months ago by Devlin
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Allow inline install for user initiated fullscreen mode Allow inline install for user initiated fullscreen mode since this mode requires that the user initiate it and due to a nuance with mac windows where the green maximize button enters fullscreen. BUG=690523 Review-Url: https://codereview.chromium.org/2693183002 Cr-Commit-Position: refs/heads/master@{#450753} (cherry picked from commit e6d00f176148e0aa1067b237a2352e99ceff751c) Review-Url: https://codereview.chromium.org/2716693002 . Cr-Commit-Position: refs/branch-heads/2987@{#665} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/029de77350f15b7d2b946c3dea196cb81d672bbd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -12 lines) Patch
M chrome/browser/extensions/webstore_inline_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/webstore_inline_installer_browsertest.cc View 3 chunks +11 lines, -10 lines 0 comments Download
M chrome/test/data/extensions/api_test/webstore_inline_install/install_from_fullscreen.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
Devlin
3 years, 10 months ago (2017-02-23 19:44:01 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
029de77350f15b7d2b946c3dea196cb81d672bbd.

Powered by Google App Engine
This is Rietveld 408576698