Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 2716593007: DevTools: Don't show CSS variables in ComputedStyleWidget unless showing all (Closed)

Created:
3 years, 10 months ago by einbinder
Modified:
3 years, 9 months ago
Reviewers:
pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, blink-reviews-style_chromium.org, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Don't show CSS variables in ComputedStyleWidget unless showing all BUG=684341 Review-Url: https://codereview.chromium.org/2716593007 Cr-Commit-Position: refs/heads/master@{#453355} Committed: https://chromium.googlesource.com/chromium/src/+/edfbdf7b37591a2eede4f68d705deb867eb837e2

Patch Set 1 #

Patch Set 2 : merge #

Patch Set 3 : Reset test result #

Patch Set 4 : Reset test result #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -15 lines) Patch
M third_party/WebKit/LayoutTests/inspector/elements/styles-3/styles-variables-expected.txt View 1 2 3 chunks +0 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/ComputedStyleWidget.js View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
einbinder
ptal
3 years, 10 months ago (2017-02-25 00:34:15 UTC) #2
pfeldman
lgtm
3 years, 10 months ago (2017-02-25 00:38:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2716593007/1
3 years, 10 months ago (2017-02-25 00:39:02 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/217876) android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, ...
3 years, 10 months ago (2017-02-25 00:40:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2716593007/20001
3 years, 9 months ago (2017-02-27 19:00:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2716593007/60001
3 years, 9 months ago (2017-02-27 20:13:50 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 22:11:57 UTC) #16
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/edfbdf7b37591a2eede4f68d705d...

Powered by Google App Engine
This is Rietveld 408576698