Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issue 2716593006: Remove PowerUsageMonitor. (Closed)

Created:
3 years, 10 months ago by Lei Zhang
Modified:
3 years, 9 months ago
Reviewers:
Mark P, shrike, brucedawson
CC:
chromium-reviews, asvitkine+watch_chromium.org, benry
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove PowerUsageMonitor. It is no longer reporting good data and other power benchmarks are being developed. Review-Url: https://codereview.chromium.org/2716593006 Cr-Commit-Position: refs/heads/master@{#456264} Committed: https://chromium.googlesource.com/chromium/src/+/43624541fe9d3f03badfab95ab582d4530318154

Patch Set 1 #

Total comments: 4

Patch Set 2 : Adjust comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -565 lines) Patch
M chrome/browser/BUILD.gn View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chrome_browser_main.h View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 1 1 chunk +0 lines, -8 lines 0 comments Download
D chrome/browser/power_usage_monitor/power_usage_monitor.h View 1 chunk +0 lines, -130 lines 0 comments Download
D chrome/browser/power_usage_monitor/power_usage_monitor.cc View 1 chunk +0 lines, -254 lines 0 comments Download
D chrome/browser/power_usage_monitor/power_usage_monitor_unittest.cc View 1 chunk +0 lines, -165 lines 0 comments Download
M chrome/test/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 4 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 31 (16 generated)
brucedawson
lgtm
3 years, 10 months ago (2017-02-24 23:38:43 UTC) #6
Lei Zhang
+mpearson for histograms.
3 years, 10 months ago (2017-02-24 23:41:36 UTC) #8
Mark P
https://codereview.chromium.org/2716593006/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2716593006/diff/1/tools/metrics/histograms/histograms.xml#newcode50064 tools/metrics/histograms/histograms.xml:50064: + Deprecated 02/2017 in favor of better power benchmarks. ...
3 years, 10 months ago (2017-02-24 23:42:35 UTC) #9
Mark P
oops, meant to lgtm with my one nit (posted on an earlier message) --mark
3 years, 9 months ago (2017-02-27 23:48:35 UTC) #10
Lei Zhang
https://codereview.chromium.org/2716593006/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2716593006/diff/1/tools/metrics/histograms/histograms.xml#newcode50064 tools/metrics/histograms/histograms.xml:50064: + Deprecated 02/2017 in favor of better power benchmarks. ...
3 years, 9 months ago (2017-02-28 00:40:50 UTC) #11
Mark P
https://codereview.chromium.org/2716593006/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2716593006/diff/1/tools/metrics/histograms/histograms.xml#newcode50064 tools/metrics/histograms/histograms.xml:50064: + Deprecated 02/2017 in favor of better power benchmarks. ...
3 years, 9 months ago (2017-02-28 00:42:18 UTC) #12
Lei Zhang
https://codereview.chromium.org/2716593006/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2716593006/diff/1/tools/metrics/histograms/histograms.xml#newcode50064 tools/metrics/histograms/histograms.xml:50064: + Deprecated 02/2017 in favor of better power benchmarks. ...
3 years, 9 months ago (2017-02-28 02:27:36 UTC) #14
Mark P
still histograms.xml lgtm
3 years, 9 months ago (2017-02-28 04:45:52 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2716593006/20001
3 years, 9 months ago (2017-03-11 02:50:27 UTC) #22
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/43624541fe9d3f03badfab95ab582d4530318154
3 years, 9 months ago (2017-03-11 02:56:42 UTC) #25
shrike
Hello thestig@, Why isn't there a bug that discusses the reason for removing this monitor? ...
3 years, 9 months ago (2017-03-12 20:17:17 UTC) #27
Lei Zhang
On 2017/03/12 20:17:17, shrike wrote: > Hello thestig@, > > Why isn't there a bug ...
3 years, 9 months ago (2017-03-13 18:51:13 UTC) #28
blundell
On 2017/03/13 18:51:13, Lei Zhang (super slow) wrote: > On 2017/03/12 20:17:17, shrike wrote: > ...
3 years, 9 months ago (2017-03-20 08:26:29 UTC) #29
shrike
On 2017/03/20 08:26:29, blundell wrote: > shrike@/thestig@: If you revert this CL, do you mind ...
3 years, 9 months ago (2017-03-24 16:48:11 UTC) #30
shrike
3 years, 9 months ago (2017-03-24 16:48:12 UTC) #31
Message was sent while issue was closed.
On 2017/03/20 08:26:29, blundell wrote:
> shrike@/thestig@: If you revert this CL, do you mind reopening
crbug.com/686011
> as well? Thanks!
> 
> Conversely, note that if you *don't* reland this code soon, //device/battery
> will become completely hidden inside the Device Service, and whatever new
> approach is taken will need to interact with the Device Sevice via
> //services/device/public/interfaces/battery_monitor.mojom instead (which
> shouldn't be hard, and I can help there).

At the moment I'm not convinced of the usefulness of this metric.

Powered by Google App Engine
This is Rietveld 408576698