third_party/WebKit/Source/core/style/ComputedStyle.h - Issue 2716583005: Do not promote position sticky or fixed elements unless they move with scroll.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/style/ComputedStyle.h

Issue 2716583005: Do not promote position sticky or fixed elements unless they move with scroll. (Closed)

Patch Set: Avoid computing constraints for non-anchored sticky and add/update tests. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/style/ComputedStyle.h

diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.h b/third_party/WebKit/Source/core/style/ComputedStyle.h

index f65eff3634047a68b26a93060453eab516b77654..9fc57ab2fb7a18c0a1b36749a7ba33e944ab0e24 100644

--- a/third_party/WebKit/Source/core/style/ComputedStyle.h

+++ b/third_party/WebKit/Source/core/style/ComputedStyle.h

@@ -3124,7 +3124,12 @@ class CORE_EXPORT ComputedStyle : public ComputedStyleBase,

position() == EPosition::kSticky;

}

bool hasViewportConstrainedPosition() const {

- return position() == EPosition::kFixed || position() == EPosition::kSticky;

+ return position() == EPosition::kFixed;

+ }

+ bool hasStickyConstrainedPosition() const {

+ return position() == EPosition::kSticky &&

+ (!top().isAuto() || !left().isAuto() || !right().isAuto() ||

+ !bottom().isAuto());

}

// Clip utility functions.