third_party/WebKit/Source/core/style/ComputedStyle.cpp - Issue 2716583005: Do not promote position sticky or fixed elements unless they move with scroll.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/style/ComputedStyle.cpp

Issue 2716583005: Do not promote position sticky or fixed elements unless they move with scroll. (Closed)

Patch Set: Avoid computing constraints for non-anchored sticky and add/update tests. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/style/ComputedStyle.cpp

diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.cpp b/third_party/WebKit/Source/core/style/ComputedStyle.cpp

index 1a07e189c1ca942ee2389360984bf78d3f62f0f8..3bad30c2f33f8b0444314bc2930504e443cd67c1 100644

--- a/third_party/WebKit/Source/core/style/ComputedStyle.cpp

+++ b/third_party/WebKit/Source/core/style/ComputedStyle.cpp

@@ -1186,7 +1186,7 @@ void ComputedStyle::updateIsStackingContext(bool isDocumentElement,

hasOpacity() || hasTransformRelatedProperty() || hasMask() ||

clipPath() || boxReflect() || hasFilterInducingProperty() ||

hasBackdropFilter() || hasBlendMode() || hasIsolation() ||

- hasViewportConstrainedPosition() ||

+ hasViewportConstrainedPosition() || position() == EPosition::kSticky ||

hasPropertyThatCreatesStackingContext(willChangeProperties()) ||

containsPaint()) {

setIsStackingContext(true);