third_party/WebKit/Source/core/paint/PaintLayer.h - Issue 2716583005: Do not promote position sticky or fixed elements unless they move with scroll.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayer.h

Issue 2716583005: Do not promote position sticky or fixed elements unless they move with scroll. (Closed)

Patch Set: Create a stacking context for sticky. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/paint/PaintLayer.h

diff --git a/third_party/WebKit/Source/core/paint/PaintLayer.h b/third_party/WebKit/Source/core/paint/PaintLayer.h

index 722352becf6fc58e6e514082a7718b0e50d9d824..c5e304154247292aef688326c840a8346aafe341 100644

--- a/third_party/WebKit/Source/core/paint/PaintLayer.h

+++ b/third_party/WebKit/Source/core/paint/PaintLayer.h

@@ -617,7 +617,8 @@ class CORE_EXPORT PaintLayer : public DisplayItemClient {

bool isInTopLayer() const;

- bool sticksToViewport() const;

+ bool sticksToScroller() const;

chrishtr 2017/03/16 00:24:04 Please add comments documenting these.

flackr 2017/03/20 21:04:59 Done.

+ bool fixedToViewport() const;

bool scrollsWithRespectTo(const PaintLayer*) const;

void addLayerHitTestRects(LayerHitTestRects&) const;