Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1111)

Side by Side Diff: third_party/WebKit/Source/core/paint/PaintLayer.h

Issue 2716583005: Do not promote position sticky or fixed elements unless they move with scroll. (Closed)
Patch Set: Create a stacking context for sticky. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved.
3 * Copyright (C) 2013 Intel Corporation. All rights reserved. 3 * Copyright (C) 2013 Intel Corporation. All rights reserved.
4 * 4 *
5 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 5 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
6 * 6 *
7 * Other contributors: 7 * Other contributors:
8 * Robert O'Callahan <roc+@cs.cmu.edu> 8 * Robert O'Callahan <roc+@cs.cmu.edu>
9 * David Baron <dbaron@fas.harvard.edu> 9 * David Baron <dbaron@fas.harvard.edu>
10 * Christian Biesinger <cbiesinger@web.de> 10 * Christian Biesinger <cbiesinger@web.de>
(...skipping 599 matching lines...) Expand 10 before | Expand all | Expand 10 after
610 610
611 void updateFilters(const ComputedStyle* oldStyle, 611 void updateFilters(const ComputedStyle* oldStyle,
612 const ComputedStyle& newStyle); 612 const ComputedStyle& newStyle);
613 void updateClipPath(const ComputedStyle* oldStyle, 613 void updateClipPath(const ComputedStyle* oldStyle,
614 const ComputedStyle& newStyle); 614 const ComputedStyle& newStyle);
615 615
616 Node* enclosingNode() const; 616 Node* enclosingNode() const;
617 617
618 bool isInTopLayer() const; 618 bool isInTopLayer() const;
619 619
620 bool sticksToViewport() const; 620 bool sticksToScroller() const;
chrishtr 2017/03/16 00:24:04 Please add comments documenting these.
flackr 2017/03/20 21:04:59 Done.
621 bool fixedToViewport() const;
621 bool scrollsWithRespectTo(const PaintLayer*) const; 622 bool scrollsWithRespectTo(const PaintLayer*) const;
622 623
623 void addLayerHitTestRects(LayerHitTestRects&) const; 624 void addLayerHitTestRects(LayerHitTestRects&) const;
624 625
625 // Compute rects only for this layer 626 // Compute rects only for this layer
626 void computeSelfHitTestRects(LayerHitTestRects&) const; 627 void computeSelfHitTestRects(LayerHitTestRects&) const;
627 628
628 // FIXME: This should probably return a ScrollableArea but a lot of internal 629 // FIXME: This should probably return a ScrollableArea but a lot of internal
629 // methods are mistakenly exposed. 630 // methods are mistakenly exposed.
630 PaintLayerScrollableArea* getScrollableArea() const { 631 PaintLayerScrollableArea* getScrollableArea() const {
(...skipping 625 matching lines...) Expand 10 before | Expand all | Expand 10 after
1256 1257
1257 } // namespace blink 1258 } // namespace blink
1258 1259
1259 #ifndef NDEBUG 1260 #ifndef NDEBUG
1260 // Outside the WebCore namespace for ease of invocation from gdb. 1261 // Outside the WebCore namespace for ease of invocation from gdb.
1261 CORE_EXPORT void showLayerTree(const blink::PaintLayer*); 1262 CORE_EXPORT void showLayerTree(const blink::PaintLayer*);
1262 CORE_EXPORT void showLayerTree(const blink::LayoutObject*); 1263 CORE_EXPORT void showLayerTree(const blink::LayoutObject*);
1263 #endif 1264 #endif
1264 1265
1265 #endif // Layer_h 1266 #endif // Layer_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698