third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.h - Issue 2716583005: Do not promote position sticky or fixed elements unless they move with scroll.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.h

Issue 2716583005: Do not promote position sticky or fixed elements unless they move with scroll. (Closed)

Patch Set: Create a stacking context for sticky. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp ('K') | « third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp ('k') | third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp » ('j') | third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinderTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.h

diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.h b/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.h

index dfb2f8b1817fe31c79293423d504b966fae41f29..887cffbd5a7aefc9571442ae93dcfaa8d658fd28 100644

--- a/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.h

+++ b/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.h

@@ -26,11 +26,10 @@ class CORE_EXPORT CompositingReasonFinder {

explicit CompositingReasonFinder(LayoutView&);

CompositingReasons potentialCompositingReasonsFromStyle(LayoutObject&) const;

- CompositingReasons directReasons(const PaintLayer*) const;

+ CompositingReasons directReasons(const PaintLayer*, bool ignoreLCDText) const;

chrishtr 2017/03/16 00:24:04 Please add a comment explaining what ignoreLCDText

flackr 2017/03/20 21:04:59 Done.

void updateTriggers();

- bool hasOverflowScrollTrigger() const;

bool requiresCompositingForScrollableFrame() const;

static bool requiresCompositingForAnimation(const ComputedStyle&);

static bool requiresCompositingForOpacityAnimation(const ComputedStyle&);

@@ -44,8 +43,10 @@ class CORE_EXPORT CompositingReasonFinder {

private:

bool isMainFrame() const;

- CompositingReasons nonStyleDeterminedDirectReasons(const PaintLayer*) const;

- bool requiresCompositingForScrollDependentPosition(const PaintLayer*) const;

+ CompositingReasons nonStyleDeterminedDirectReasons(const PaintLayer*,

+ bool ignoreLCDText) const;

+ bool requiresCompositingForScrollDependentPosition(const PaintLayer*,

+ bool ignoreLCDText) const;

LayoutView& m_layoutView;

CompositingTriggerFlags m_compositingTriggers;