Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

Issue 2716583005: Do not promote position sticky or fixed elements unless they move with scroll. (Closed)
Patch Set: Create a stacking context for sticky. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp b/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
index 0507c39044c21b83f227d51c5649d5bdfa0a6e7d..04499a19bb9fc83ed63374cc4d1eafdc5cd98d7f 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
@@ -249,7 +249,8 @@ void LayoutBoxModelObject::willBeDestroyed() {
// 0 during destruction.
if (LocalFrame* frame = this->frame()) {
if (FrameView* frameView = frame->view()) {
- if (style()->hasViewportConstrainedPosition())
+ if (style()->hasViewportConstrainedPosition() ||
+ style()->hasStickyConstrainedPosition())
chrishtr 2017/03/16 00:24:03 This was a bug before?
flackr 2017/03/20 21:04:59 Not so much a bug, just hasStickyConstrainedPositi
frameView->removeViewportConstrainedObject(*this);
}
}

Powered by Google App Engine
This is Rietveld 408576698