Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 2716583004: cc: Remove SetNeedsUpdate function from cc::Layer (Closed)

Created:
3 years, 10 months ago by weiliangc
Modified:
3 years, 9 months ago
Reviewers:
danakj
CC:
cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Remove SetNeedsUpdate function from cc::Layer Remove SetNeedsUpdate call from cc::Layer to try reduce confusion. Move animation use case to LayerTreeHost direct, and call LayerTreeHost directly in one remaining case. R=danakj BUG=695681 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2716583004 Cr-Commit-Position: refs/heads/master@{#453335} Committed: https://chromium.googlesource.com/chromium/src/+/1d914bf6e03df6f7649638827df8d2e4de95192c

Patch Set 1 #

Total comments: 4

Patch Set 2 : add/edit/transport comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -133 lines) Patch
M cc/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/layers/layer.h View 1 3 chunks +8 lines, -11 lines 0 comments Download
M cc/layers/layer.cc View 4 chunks +2 lines, -53 lines 0 comments Download
M cc/layers/layer_unittest.cc View 1 2 chunks +11 lines, -6 lines 0 comments Download
D cc/test/layer_internals_for_test.h View 1 chunk +0 lines, -28 lines 0 comments Download
D cc/test/layer_internals_for_test.cc View 1 chunk +0 lines, -27 lines 0 comments Download
M cc/trees/layer_tree_host.h View 2 chunks +3 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host.cc View 1 8 chunks +45 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 3 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 25 (18 generated)
weiliangc
3 years, 10 months ago (2017-02-24 00:19:23 UTC) #2
danakj
LGTM w/ comments https://codereview.chromium.org/2716583004/diff/1/cc/layers/layer.h File cc/layers/layer.h (right): https://codereview.chromium.org/2716583004/diff/1/cc/layers/layer.h#newcode350 cc/layers/layer.h:350: // Mark current layers as need ...
3 years, 10 months ago (2017-02-24 00:52:38 UTC) #8
weiliangc
Addressed review comments and added TODO.
3 years, 10 months ago (2017-02-24 22:51:29 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2716583004/20001
3 years, 10 months ago (2017-02-24 22:52:33 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_trusty_blink_rel on master.tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_trusty_blink_rel/builds/5627)
3 years, 10 months ago (2017-02-25 00:42:51 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2716583004/20001
3 years, 9 months ago (2017-02-27 21:04:53 UTC) #22
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 21:11:20 UTC) #25
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1d914bf6e03df6f7649638827df8...

Powered by Google App Engine
This is Rietveld 408576698