cc: Remove SetNeedsUpdate function from cc::Layer

cc: Remove SetNeedsUpdate function from cc::Layer

Remove SetNeedsUpdate call from cc::Layer to try reduce confusion.
Move animation use case to LayerTreeHost direct, and call LayerTreeHost
directly in one remaining case.

R=danakj
BUG=695681
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2716583004
Cr-Commit-Position: refs/heads/master@{#453335}
Committed: https://chromium.googlesource.com/chromium/src/+/1d914bf6e03df6f7649638827df8d2e4de95192c

[weiliangc, 2017-02-24 00:18:55]

Description was changed from

==========
cc: Remove SetNeedsUpdate function from cc::Layer

Remove SetNeedsUpdate call from cc::Layer to try reduce confusion.
Move animation use case to LayerTreeHost direct, and call LayerTreeHost
directly in one remaining case.

R=danakj
BUG=695681
==========

to

==========
cc: Remove SetNeedsUpdate function from cc::Layer

Remove SetNeedsUpdate call from cc::Layer to try reduce confusion.
Move animation use case to LayerTreeHost direct, and call LayerTreeHost
directly in one remaining case.

R=danakj
BUG=695681
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[weiliangc, 2017-02-24 00:19:54]

The CQ bit was checked by weiliangc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 00:20:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[weiliangc, 2017-02-24 00:21:26]

The CQ bit was unchecked by weiliangc@chromium.org

[weiliangc, 2017-02-24 00:42:46]

The CQ bit was checked by weiliangc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 00:43:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2017-02-24 00:52:38]

LGTM w/ comments

https://codereview.chromium.org/2716583004/diff/1/cc/layers/layer.h
File cc/layers/layer.h (right):

https://codereview.chromium.org/2716583004/diff/1/cc/layers/layer.h#newcode350
cc/layers/layer.h:350: // Mark current layers as need to push properties that
are changed to impl
"Mark the layer as needing to push its properties to the LayerImpl during
commit"

https://codereview.chromium.org/2716583004/diff/1/cc/layers/layer_unittest.cc
File cc/layers/layer_unittest.cc (right):

https://codereview.chromium.org/2716583004/diff/1/cc/layers/layer_unittest.cc...
cc/layers/layer_unittest.cc:1383: TEST_F(LayerTest,
AnimationSchedulesLayerUpdate) {
This doesnt look like a LayerTest anymore

https://codereview.chromium.org/2716583004/diff/1/cc/trees/layer_tree_host.cc
File cc/trees/layer_tree_host.cc (right):

https://codereview.chromium.org/2716583004/diff/1/cc/trees/layer_tree_host.cc...
cc/trees/layer_tree_host.cc:278: this, [](Layer* layer) {
layer->SetNeedsPushProperties(); });
Can you transplant the comment about why we're doing this?

https://codereview.chromium.org/2716583004/diff/1/cc/trees/layer_tree_host.cc...
cc/trees/layer_tree_host.cc:1244: if
(property_trees_.IsInIdToIndexMap(PropertyTrees::TreeType::TRANSFORM,
nit: maybe im being pedantic but can you make the whitespace story similar
between these two methods?

[commit-bot: I haz the power, 2017-02-24 02:17:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 02:17:35]

Dry run: This issue passed the CQ dry run.

[weiliangc, 2017-02-24 22:51:29]

Addressed review comments and added TODO.

[weiliangc, 2017-02-24 22:51:34]

The CQ bit was checked by weiliangc@chromium.org

[weiliangc, 2017-02-24 22:51:35]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/2716583004/#ps20001
(title: "add/edit/transport comments")

[commit-bot: I haz the power, 2017-02-24 22:52:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-25 00:42:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-25 00:42:51]

Try jobs failed on following builders:
  linux_trusty_blink_rel on master.tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_trusty_blink_rel/b...)

[weiliangc, 2017-02-27 19:26:18]

The CQ bit was checked by weiliangc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 19:26:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 20:48:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 20:48:02]

Dry run: This issue passed the CQ dry run.

[weiliangc, 2017-02-27 21:04:08]

The CQ bit was checked by weiliangc@chromium.org

[commit-bot: I haz the power, 2017-02-27 21:04:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 21:10:40]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488229448459840,
"parent_rev": "028009c724049003f9e3e25cbcaef43f26bf59c8", "commit_rev":
"1d914bf6e03df6f7649638827df8d2e4de95192c"}

[commit-bot: I haz the power, 2017-02-27 21:11:18]

Description was changed from

==========
cc: Remove SetNeedsUpdate function from cc::Layer

Remove SetNeedsUpdate call from cc::Layer to try reduce confusion.
Move animation use case to LayerTreeHost direct, and call LayerTreeHost
directly in one remaining case.

R=danakj
BUG=695681
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Remove SetNeedsUpdate function from cc::Layer

Remove SetNeedsUpdate call from cc::Layer to try reduce confusion.
Move animation use case to LayerTreeHost direct, and call LayerTreeHost
directly in one remaining case.

R=danakj
BUG=695681
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2716583004
Cr-Commit-Position: refs/heads/master@{#453335}
Committed:
https://chromium.googlesource.com/chromium/src/+/1d914bf6e03df6f7649638827df8...
==========

[commit-bot: I haz the power, 2017-02-27 21:11:20]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1d914bf6e03df6f7649638827df8...