components/password_manager/core/browser/credential_manager_pending_request_task.cc - Issue 2716583003: Rename Origin.unique() to opaque().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/credential_manager_pending_request_task.cc

Issue 2716583003: Rename Origin.unique() to opaque().

Patch Set: Update new uses post-rebase Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/credential_manager_impl_unittest.cc ('k') | components/password_manager/core/browser/form_fetcher_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/credential_manager_pending_request_task.cc

diff --git a/components/password_manager/core/browser/credential_manager_pending_request_task.cc b/components/password_manager/core/browser/credential_manager_pending_request_task.cc

index f6e98544ab5cd3dd04d380502e3db1d0faa6176f..25de079d005b256b918e8052c897527fd8211527 100644

--- a/components/password_manager/core/browser/credential_manager_pending_request_task.cc

+++ b/components/password_manager/core/browser/credential_manager_pending_request_task.cc

@@ -71,7 +71,7 @@ void FilterDuplicates(

std::unique_ptr<autofill::PasswordForm>>

credentials;

for (auto& form : *forms) {

- if (!form->federation_origin.unique()) {

+ if (!form->federation_origin.opaque()) {

federated_forms.push_back(std::move(form));

} else {

auto key = std::make_pair(

@@ -161,8 +161,8 @@ void CredentialManagerPendingRequestTask::ProcessForms(

for (auto& form : results) {

// Ensure that the form we're looking at matches the password and

// federation filters provided.

- if (!((form->federation_origin.unique() && include_passwords_) ||

- (!form->federation_origin.unique() &&

+ if (!((form->federation_origin.opaque() && include_passwords_) ||

+ (!form->federation_origin.opaque() &&

federations_.count(form->federation_origin.Serialize())))) {

continue;

}

@@ -198,7 +198,7 @@ void CredentialManagerPendingRequestTask::ProcessForms(

!password_bubble_experiment::ShouldShowAutoSignInPromptFirstRunExperience(

delegate_->client()->GetPrefs())) {

CredentialInfo info(*local_results[0],

- local_results[0]->federation_origin.unique()

+ local_results[0]->federation_origin.opaque()

? CredentialType::CREDENTIAL_TYPE_PASSWORD

: CredentialType::CREDENTIAL_TYPE_FEDERATED);

delegate_->client()->NotifyUserAutoSignin(std::move(local_results),