components/password_manager/core/browser/password_syncable_service_unittest.cc - Issue 2716583003: Rename Origin.unique() to opaque().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_syncable_service_unittest.cc

Issue 2716583003: Rename Origin.unique() to opaque().

Patch Set: Mac fixes Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/password_syncable_service.cc ('k') | components/password_manager/core/browser/psl_matching_helper.cc » ('j') | content/browser/bluetooth/bluetooth_device_chooser_controller.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_syncable_service_unittest.cc

diff --git a/components/password_manager/core/browser/password_syncable_service_unittest.cc b/components/password_manager/core/browser/password_syncable_service_unittest.cc

index bb3a731bfc9e79db44cc7c94de8f7139be63f6a9..3b3363ac5cc114cb929d959d1f30881c9e52ffd3 100644

--- a/components/password_manager/core/browser/password_syncable_service_unittest.cc

+++ b/components/password_manager/core/browser/password_syncable_service_unittest.cc

@@ -589,7 +589,7 @@ TEST_F(PasswordSyncableServiceTest, MergeEmptyPasswords) {

// string.

TEST_F(PasswordSyncableServiceTest, SerializeEmptyFederation) {

autofill::PasswordForm form;

- EXPECT_TRUE(form.federation_origin.unique());

+ EXPECT_TRUE(form.federation_origin.opaque());

syncer::SyncData data = SyncDataFromPassword(form);

const sync_pb::PasswordSpecificsData& specifics = GetPasswordSpecifics(data);

EXPECT_TRUE(specifics.has_federation_url());

@@ -597,7 +597,7 @@ TEST_F(PasswordSyncableServiceTest, SerializeEmptyFederation) {

// Deserialize back.

form = PasswordFromSpecifics(specifics);

- EXPECT_TRUE(form.federation_origin.unique());

+ EXPECT_TRUE(form.federation_origin.opaque());

// Make sure that the Origins uploaded incorrectly are still deserialized

// correctly.

@@ -605,7 +605,7 @@ TEST_F(PasswordSyncableServiceTest, SerializeEmptyFederation) {

sync_pb::PasswordSpecificsData specifics1;

specifics1.set_federation_url("null");

form = PasswordFromSpecifics(specifics1);

- EXPECT_TRUE(form.federation_origin.unique());

+ EXPECT_TRUE(form.federation_origin.opaque());

}

// Serialize empty PasswordForm and make sure the Sync representation is