components/password_manager/core/browser/password_syncable_service.cc - Issue 2716583003: Rename Origin.unique() to opaque().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_syncable_service.cc

Issue 2716583003: Rename Origin.unique() to opaque().

Patch Set: Mac fixes Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/password_manager_util.cc ('k') | components/password_manager/core/browser/password_syncable_service_unittest.cc » ('j') | content/browser/bluetooth/bluetooth_device_chooser_controller.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_syncable_service.cc

diff --git a/components/password_manager/core/browser/password_syncable_service.cc b/components/password_manager/core/browser/password_syncable_service.cc

index 03746ff6a06f6fc24949a4862f4c6e13f510ec9a..a1d10a46cceaa261a61ca6b4410a0f317992bcef 100644

--- a/components/password_manager/core/browser/password_syncable_service.cc

+++ b/components/password_manager/core/browser/password_syncable_service.cc

@@ -465,7 +465,7 @@ syncer::SyncData SyncDataFromPassword(

CopyStringField(display_name);

password_specifics->set_avatar_url(password_form.icon_url.spec());

password_specifics->set_federation_url(

- password_form.federation_origin.unique()

+ password_form.federation_origin.opaque()

? std::string()

: password_form.federation_origin.Serialize());

#undef CopyStringField