Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 2716563002: Crashpad: ALLOW_UNUSED_LOCAL things that are only used in DPLOG_IF. (Closed)

Created:
3 years, 10 months ago by Mark Mentovai
Modified:
3 years, 8 months ago
Reviewers:
ranjitkan
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Crashpad: ALLOW_UNUSED_LOCAL things that are only used in DPLOG_IF. BUG=695314 TBR=ranjitkan@chromium.org Was reverted instead. See https://crbug.com/695314

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M third_party/crashpad/README.chromium View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/handler/handler_main.cc View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2716563002/1
3 years, 10 months ago (2017-02-23 05:20:53 UTC) #3
Mark Mentovai
3 years, 10 months ago (2017-02-23 05:23:31 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 06:14:50 UTC) #7
Failed to apply patch for third_party/crashpad/README.chromium:
While running git apply --index -p1;
  error: patch failed: third_party/crashpad/README.chromium:35
  error: third_party/crashpad/README.chromium: patch does not apply

Patch:       third_party/crashpad/README.chromium
Index: third_party/crashpad/README.chromium
diff --git a/third_party/crashpad/README.chromium
b/third_party/crashpad/README.chromium
index
6c0ddb06effe2b312c542b62fd888be99e79364b..790468277e0dd0475e239fb9e2fd3dcd1fcde8e4
100644
--- a/third_party/crashpad/README.chromium
+++ b/third_party/crashpad/README.chromium
@@ -35,4 +35,5 @@ $ cd "${CRASHPAD_DIR}"
 $ git am --3way --message-id -p4 /tmp/patchdir
 
 Local Modifications:
-None.
+ - ALLOW_UNUSED_LOCAL things that are only used in DPLOG_IF.
+   https://crbug.com/695314

Powered by Google App Engine
This is Rietveld 408576698