Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(954)

Unified Diff: third_party/crashpad/crashpad/handler/handler_main.cc

Issue 2716563002: Crashpad: ALLOW_UNUSED_LOCAL things that are only used in DPLOG_IF. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/crashpad/README.chromium ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/crashpad/crashpad/handler/handler_main.cc
diff --git a/third_party/crashpad/crashpad/handler/handler_main.cc b/third_party/crashpad/crashpad/handler/handler_main.cc
index c7c2b29738bde496f39cd31c8594fc8946ff5456..153607be078ce0433bd68472769462fdae98dd8c 100644
--- a/third_party/crashpad/crashpad/handler/handler_main.cc
+++ b/third_party/crashpad/crashpad/handler/handler_main.cc
@@ -165,6 +165,7 @@ void RestoreDefaultSignalHandler(int sig) {
sa.sa_handler = SIG_DFL;
int rv = sigaction(sig, &sa, nullptr);
DPLOG_IF(ERROR, rv != 0) << "sigaction " << sig;
+ ALLOW_UNUSED_LOCAL(rv); // https://crbug.com/695314
}
void HandleCrashSignal(int sig, siginfo_t* siginfo, void* context) {
@@ -240,6 +241,7 @@ void HandleCrashSignal(int sig, siginfo_t* siginfo, void* context) {
// initially triggered.
int rv = raise(sig);
DPLOG_IF(ERROR, rv != 0) << "raise";
+ ALLOW_UNUSED_LOCAL(rv); // https://crbug.com/695314
}
}
@@ -253,6 +255,7 @@ void HandleTerminateSignal(int sig, siginfo_t* siginfo, void* context) {
// because termination signals never originate in that way.
int rv = raise(sig);
DPLOG_IF(ERROR, rv != 0) << "raise";
+ ALLOW_UNUSED_LOCAL(rv); // https://crbug.com/695314
}
void InstallCrashHandler() {
« no previous file with comments | « third_party/crashpad/README.chromium ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698