Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Issue 2716553002: Explicitly set charset to Blink perf resource hindi-line-layout.html (Closed)

Created:
3 years, 10 months ago by Jinsuk Kim
Modified:
3 years, 10 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Explicitly set charset to Blink perf resource hindi-line-layout.html A recent change https://crrev.com/2697213002 caused a regression in one Blink layout performance test. This CL fixes it by setting the encoding label explicitly in the test html to prevent the result from being affected by the text in it rendered wrongly. BUG=694550 Review-Url: https://codereview.chromium.org/2716553002 Cr-Commit-Position: refs/heads/master@{#452382} Committed: https://chromium.googlesource.com/chromium/src/+/e9bfe75886f49ffe347787389b7346dba85a313a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/WebKit/PerformanceTests/Layout/hindi-line-layout.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Jinsuk Kim
3 years, 10 months ago (2017-02-23 01:59:44 UTC) #2
Dirk Pranke
rs- lgtm.
3 years, 10 months ago (2017-02-23 02:32:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2716553002/1
3 years, 10 months ago (2017-02-23 02:42:09 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 03:55:51 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e9bfe75886f49ffe347787389b73...

Powered by Google App Engine
This is Rietveld 408576698