Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 2716513002: Add DCHECK when service handler is missing (Closed)

Created:
3 years, 10 months ago by tibell
Modified:
3 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add DCHECK when service handler is missing At this point we've already verified that the service exists and that the client is allowed to connect, so failure to create the service indicates a bug in its setup (i.e. it wasn't registered properly). BUG=694807 Review-Url: https://codereview.chromium.org/2716513002 Cr-Commit-Position: refs/heads/master@{#452344} Committed: https://chromium.googlesource.com/chromium/src/+/afa4a1208478bdad5d47151e1248eb14571aa942

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M content/common/service_manager/service_manager_connection_impl.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
tibell
3 years, 10 months ago (2017-02-22 23:51:36 UTC) #3
Ken Rockot(use gerrit already)
lgtm
3 years, 10 months ago (2017-02-23 00:26:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2716513002/1
3 years, 10 months ago (2017-02-23 01:55:08 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 02:00:08 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/afa4a1208478bdad5d47151e1248...

Powered by Google App Engine
This is Rietveld 408576698