Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1066)

Unified Diff: chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc

Issue 2716493004: Renamed NavigationHandle::IsSamePage to NavigationHandle::IsSameDocument (Closed)
Patch Set: Rebased Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc
diff --git a/chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc b/chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc
index c072c16e06f1892fd082a011ab092f52a552f9ee..54475af4e704feb2caa1d7391e0cf1b8d591d8ed 100644
--- a/chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc
+++ b/chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc
@@ -47,11 +47,11 @@ PopupBlockerTabHelper::~PopupBlockerTabHelper() {
void PopupBlockerTabHelper::DidFinishNavigation(
content::NavigationHandle* navigation_handle) {
// Clear all page actions, blocked content notifications and browser actions
- // for this tab, unless this is an in-page navigation. Also only consider
- // main frame navigations that successfully committed.
+ // for this tab, unless this is an same-document navigation. Also only
+ // consider main frame navigations that successfully committed.
if (!navigation_handle->IsInMainFrame() ||
!navigation_handle->HasCommitted() ||
- navigation_handle->IsSamePage()) {
+ navigation_handle->IsSameDocument()) {
return;
}

Powered by Google App Engine
This is Rietveld 408576698