Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Unified Diff: chrome/browser/android/offline_pages/offline_page_tab_helper.cc

Issue 2716493004: Renamed NavigationHandle::IsSamePage to NavigationHandle::IsSameDocument (Closed)
Patch Set: Rebased Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/offline_page_tab_helper.cc
diff --git a/chrome/browser/android/offline_pages/offline_page_tab_helper.cc b/chrome/browser/android/offline_pages/offline_page_tab_helper.cc
index 5ba8a727da9d14354b8bafce5ea9e9e4109530d9..43abfe9b3d3f68d79a27a7911e4ee0492c7227a0 100644
--- a/chrome/browser/android/offline_pages/offline_page_tab_helper.cc
+++ b/chrome/browser/android/offline_pages/offline_page_tab_helper.cc
@@ -56,7 +56,8 @@ void OfflinePageTabHelper::DidStartNavigation(
provisional_offline_info_.Clear();
// If not a fragment navigation, clear the cached offline info.
- if (offline_info_.offline_page.get() && !navigation_handle->IsSamePage()) {
+ if (offline_info_.offline_page.get() &&
+ !navigation_handle->IsSameDocument()) {
offline_info_.Clear();
}
}
@@ -70,7 +71,7 @@ void OfflinePageTabHelper::DidFinishNavigation(
if (!navigation_handle->HasCommitted())
return;
- if (navigation_handle->IsSamePage())
+ if (navigation_handle->IsSameDocument())
return;
GURL navigated_url = navigation_handle->GetURL();

Powered by Google App Engine
This is Rietveld 408576698