mash: Remove shelf app menu item objects.

chrome/browser/ui/ash/launcher/chrome_launcher_controller.h

Index: chrome/browser/ui/ash/launcher/chrome_launcher_controller.h
diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_controller.h b/chrome/browser/ui/ash/launcher/chrome_launcher_controller.h
index 9bba9a4536ac0ad1ffcc64411a196967ca0fb53f..d193181ee00cee0cb95f823b122fcc3218eb7223 100644
--- a/chrome/browser/ui/ash/launcher/chrome_launcher_controller.h
+++ b/chrome/browser/ui/ash/launcher/chrome_launcher_controller.h
@@ -180,10 +180,8 @@ class ChromeLauncherController : public ash::mojom::ShelfObserver,
   virtual void AdditionalUserAddedToSession(Profile* profile) = 0;
 
   // Get the list of all running incarnations of this item.
-  // |event_flags| specifies the flags which were set by the event which
-  // triggered this menu generation. It can be used to generate different lists.
-  virtual ash::ShelfAppMenuItemList GetAppMenuItems(const ash::ShelfItem& item,
-                                                    int event_flags) = 0;
+  virtual ash::ShelfAppMenuItemList GetAppMenuItemsForTest(

[James Cook, 2017/03/01 19:50:48]

optional: Do you know if we prefer ForTest vs ForTesting? I suspect we use both,
but I dunno if we have a preference for new code.

[msw, 2017/03/02 02:59:20]

Well, I prefer ForTest (it's shorter and conveys the same thing), but our style
guide mentions ForTesting:
https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md...
Also, ForTesting is also slightly more popular in the codebase: 3,675 files vs.
1,948 files...
So I changed this function to ForTesting and I'll use that from now on, I guess.

+      const ash::ShelfItem& item) = 0;
 
   // Get the list of all tabs which belong to a certain application type.
   virtual std::vector<content::WebContents*> GetV1ApplicationsFromAppId(