mash: Remove shelf app menu item objects.

chrome/browser/ui/ash/launcher/chrome_launcher_controller.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_ASH_LAUNCHER_CHROME_LAUNCHER_CONTROLLER_H_
 #define CHROME_BROWSER_UI_ASH_LAUNCHER_CHROME_LAUNCHER_CONTROLLER_H_
 
 #include <memory>
 #include <string>
 #include <vector>
@@ skipping 162 matching lines @@
       ui::BaseWindow* window,
       bool allow_minimize) = 0;
 
   // Called when the active user has changed.
   virtual void ActiveUserChanged(const std::string& user_email) = 0;
 
   // Called when a user got added to the session.
   virtual void AdditionalUserAddedToSession(Profile* profile) = 0;
 
   // Get the list of all running incarnations of this item.
-  // |event_flags| specifies the flags which were set by the event which
-  // triggered this menu generation. It can be used to generate different lists.
-  virtual ash::ShelfAppMenuItemList GetAppMenuItems(const ash::ShelfItem& item,
-                                                    int event_flags) = 0;
+  virtual ash::ShelfAppMenuItemList GetAppMenuItemsForTest(

[James Cook, 2017/03/01 19:50:48]

optional: Do you know if we prefer ForTest vs ForTesting? I suspect we use both,
but I dunno if we have a preference for new code.

[msw, 2017/03/02 02:59:20]

Well, I prefer ForTest (it's shorter and conveys the same thing), but our style
guide mentions ForTesting:
https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md...
Also, ForTesting is also slightly more popular in the codebase: 3,675 files vs.
1,948 files...
So I changed this function to ForTesting and I'll use that from now on, I guess.

+      const ash::ShelfItem& item) = 0;
 
   // Get the list of all tabs which belong to a certain application type.
   virtual std::vector<content::WebContents*> GetV1ApplicationsFromAppId(
       const std::string& app_id) = 0;
 
   // Activates a specified shell application by app id and window index.
   virtual void ActivateShellApp(const std::string& app_id,
                                 int window_index) = 0;
 
   // Checks if a given |web_contents| is known to be associated with an
@@ skipping 111 matching lines @@
   // An observer that manages the shelf title and icon for settings windows.
   SettingsWindowObserver settings_window_observer_;
 
   // Used to load the images for app items.
   std::vector<std::unique_ptr<AppIconLoader>> app_icon_loaders_;
 
   DISALLOW_COPY_AND_ASSIGN(ChromeLauncherController);
 };
 
 #endif  // CHROME_BROWSER_UI_ASH_LAUNCHER_CHROME_LAUNCHER_CONTROLLER_H_