Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1758)

Unified Diff: ash/common/shelf/shelf_controller.cc

Issue 2716403005: mash: Remove shelf app menu item objects. (Closed)
Patch Set: Fix ash_shell compile Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/common/shelf/shelf_controller.cc
diff --git a/ash/common/shelf/shelf_controller.cc b/ash/common/shelf/shelf_controller.cc
index 4e836733547918329d161f98472c4fde6acf87c8..4da9401777e8000770cabbd02f8be51721f5558f 100644
--- a/ash/common/shelf/shelf_controller.cc
+++ b/ash/common/shelf/shelf_controller.cc
@@ -74,11 +74,15 @@ class ShelfItemDelegateMus : public ShelfItemDelegate {
ShelfAppMenuItemList items;
for (const auto& window : window_id_to_title_) {
items.push_back(
- base::MakeUnique<ShelfApplicationMenuItem>(window.second));
+ base::MakeUnique<ShelfApplicationMenuItem>(0, window.second));
James Cook 2017/03/01 19:50:48 Does 0 mean invalid command, or first command, or
msw 2017/03/02 02:59:20 I removed this code and left the standard no-menu
}
return items;
}
+ void ExecuteCommand(uint32_t command_id, int32_t event_flags) override {
+ NOTIMPLEMENTED();
+ }
+
void Close() override { NOTIMPLEMENTED(); }
mojom::ShelfItemDelegateAssociatedPtr delegate_;

Powered by Google App Engine
This is Rietveld 408576698