mash: Remove shelf app menu item objects.

ash/common/shelf/shelf_controller.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/common/shelf/shelf_controller.h"
 
 #include "ash/common/shelf/shelf_item_delegate.h"
 #include "ash/common/shelf/wm_shelf.h"
 #include "ash/common/wm_lookup.h"
 #include "ash/common/wm_shell.h"
@@ skipping 56 matching lines @@
       // SHELF_ACTION_WINDOW_ACTIVATED.
       NOTIMPLEMENTED();
     }
     return SHELF_ACTION_NONE;
   }
 
   ShelfAppMenuItemList GetAppMenuItems(int event_flags) override {
     ShelfAppMenuItemList items;
     for (const auto& window : window_id_to_title_) {
       items.push_back(
-          base::MakeUnique<ShelfApplicationMenuItem>(window.second));
+          base::MakeUnique<ShelfApplicationMenuItem>(0, window.second));

[James Cook, 2017/03/01 19:50:48]

Does 0 mean invalid command, or first command, or both? If it means both it
might be nice to use -1 or something for invalid.

[msw, 2017/03/02 02:59:20]

I removed this code and left the standard no-menu comment, since this is unused
at the moment. I'll likely want to revise the |window_id_to_title_| map into a
vector of window structures with ids and titles for O(1) indexed access, etc.
Someday I'll be done with the prerequisite work to make this useful again.

     }
     return items;
   }
 
+  void ExecuteCommand(uint32_t command_id, int32_t event_flags) override {
+    NOTIMPLEMENTED();
+  }
+
   void Close() override { NOTIMPLEMENTED(); }
 
   mojom::ShelfItemDelegateAssociatedPtr delegate_;
   bool pinned_ = false;
   std::map<uint32_t, base::string16> window_id_to_title_;
   base::string16 title_;
 
   DISALLOW_COPY_AND_ASSIGN(ShelfItemDelegateMus);
 };
 
@@ skipping 142 matching lines @@
     return;
   ShelfID shelf_id = app_id_to_shelf_id_[app_id];
   int index = model_.ItemIndexByID(shelf_id);
   DCHECK_GE(index, 0);
   ShelfItem item = *model_.ItemByID(shelf_id);
   item.image = GetShelfIconFromBitmap(image);
   model_.Set(index, item);
 }
 
 }  // namespace ash