Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2716393002: Deprecate hpack_table_size flag, remove dead code. (Closed)

Created:
3 years, 9 months ago by dahollings
Modified:
3 years, 9 months ago
Reviewers:
Bence, jbudorick
CC:
chromium-reviews, cbentzel+watch_chromium.org, fuzzing_chromium.org, bnc+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Deprecate hpack_table_size flag, remove dead code. This CL lands server changes 148221046, 148224472, and 148645081 by yasong. BUG=488484 Review-Url: https://codereview.chromium.org/2716393002 Cr-Commit-Position: refs/heads/master@{#453379} Committed: https://chromium.googlesource.com/chromium/src/+/0d7bfa27e59496d5cc00ee1797d896c9f486386b

Patch Set 1 #

Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -224 lines) Patch
M BUILD.gn View 1 2 chunks +0 lines, -3 lines 0 comments Download
M net/BUILD.gn View 1 chunk +0 lines, -32 lines 0 comments Download
D net/spdy/fuzzing/hpack_fuzz_mutator.cc View 1 chunk +0 lines, -80 lines 0 comments Download
D net/spdy/fuzzing/hpack_fuzz_wrapper.cc View 1 chunk +0 lines, -59 lines 0 comments Download
M net/spdy/hpack/hpack_header_table.cc View 1 chunk +1 line, -7 lines 0 comments Download
M net/spdy/hpack/hpack_header_table_test.cc View 2 chunks +0 lines, -37 lines 0 comments Download
M net/spdy/spdy_flags.h View 1 chunk +0 lines, -2 lines 0 comments Download
M net/spdy/spdy_flags.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
dahollings
3 years, 9 months ago (2017-02-27 18:53:41 UTC) #10
Bence
LGTM.
3 years, 9 months ago (2017-02-27 23:00:44 UTC) #11
Bence
jbudorick: PTAL at BUILD.gn. Thank you.
3 years, 9 months ago (2017-02-27 23:02:55 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2716393002/20001
3 years, 9 months ago (2017-02-27 23:03:37 UTC) #15
jbudorick
On 2017/02/27 23:02:55, Bence wrote: > jbudorick: PTAL at BUILD.gn. Thank you. BUILD.gn lgtm
3 years, 9 months ago (2017-02-27 23:05:12 UTC) #16
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 23:13:34 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0d7bfa27e59496d5cc00ee1797d8...

Powered by Google App Engine
This is Rietveld 408576698