Add Active Directory enterprise enrollment/domain join tests

Add Active Directory enterprise enrollment/domain join tests

BUG=682421
TEST=EnterpriseEnrollmentTest.TestActiveDirectoryEnrollment*

Review-Url: https://codereview.chromium.org/2716383002
Cr-Commit-Position: refs/heads/master@{#453253}
Committed: https://chromium.googlesource.com/chromium/src/+/6dfec867c5ee0e640d48b099ef28776659fb54ea

[Roman Sorokin (ftl), 2017-02-27 15:55:43]

rsorokin@chromium.org changed reviewers:
+ achuith@chromium.org

[Roman Sorokin (ftl), 2017-02-27 15:55:44]

Hey Achuith, PTAL. Thanks!

[Roman Sorokin (ftl), 2017-02-27 15:56:03]

The CQ bit was checked by rsorokin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 15:56:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[achuithb, 2017-02-27 16:03:48]

lgtm

https://codereview.chromium.org/2716383002/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/enterprise_enrollment_browsertest.cc (right):

https://codereview.chromium.org/2716383002/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/enterprise_enrollment_browsertest.cc:29: const
char ad_machine_name_input[] =
Shouldn't this be kAdMachineNameInput? Same for rest

https://codereview.chromium.org/2716383002/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/enterprise_enrollment_browsertest.cc:94: void
SubmitActiveDirectoryCredentials(const std::string& machine_name,
Function comment.

https://codereview.chromium.org/2716383002/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/enterprise_enrollment_browsertest.cc:144: void
SetupActiveDirectoryJoin() {
Function comment

https://codereview.chromium.org/2716383002/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/enterprise_enrollment_browsertest.cc:297:
SubmitActiveDirectoryCredentials("machine_name", ad_test_user, "password");
Some more newlines in this test would help readability

[Roman Sorokin (ftl), 2017-02-27 16:20:13]

The CQ bit was checked by rsorokin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 16:20:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Roman Sorokin (ftl), 2017-02-27 16:20:49]

https://codereview.chromium.org/2716383002/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/enterprise_enrollment_browsertest.cc (right):

https://codereview.chromium.org/2716383002/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/enterprise_enrollment_browsertest.cc:29: const
char ad_machine_name_input[] =
On 2017/02/27 16:03:47, achuithb wrote:
> Shouldn't this be kAdMachineNameInput? Same for rest

yeah, my bad.

https://codereview.chromium.org/2716383002/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/enterprise_enrollment_browsertest.cc:94: void
SubmitActiveDirectoryCredentials(const std::string& machine_name,
On 2017/02/27 16:03:47, achuithb wrote:
> Function comment.

Done.

https://codereview.chromium.org/2716383002/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/enterprise_enrollment_browsertest.cc:144: void
SetupActiveDirectoryJoin() {
On 2017/02/27 16:03:47, achuithb wrote:
> Function comment

Done.

https://codereview.chromium.org/2716383002/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/enterprise_enrollment_browsertest.cc:297:
SubmitActiveDirectoryCredentials("machine_name", ad_test_user, "password");
On 2017/02/27 16:03:47, achuithb wrote:
> Some more newlines in this test would help readability

Done.

[commit-bot: I haz the power, 2017-02-27 16:49:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 16:49:40]

Dry run: This issue passed the CQ dry run.

[Roman Sorokin (ftl), 2017-02-27 17:51:31]

The CQ bit was checked by rsorokin@chromium.org

[Roman Sorokin (ftl), 2017-02-27 17:51:32]

The patchset sent to the CQ was uploaded after l-g-t-m from achuith@chromium.org
Link to the patchset: https://codereview.chromium.org/2716383002/#ps20001
(title: "Update after review")

[commit-bot: I haz the power, 2017-02-27 17:52:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 17:58:46]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488217891623390,
"parent_rev": "55850d4e8fca1b77851f90956fe3dd995b01afc0", "commit_rev":
"6dfec867c5ee0e640d48b099ef28776659fb54ea"}

[commit-bot: I haz the power, 2017-02-27 17:59:29]

Description was changed from

==========
Add Active Directory enterprise enrollment/domain join tests

BUG=682421
TEST=EnterpriseEnrollmentTest.TestActiveDirectoryEnrollment*
==========

to

==========
Add Active Directory enterprise enrollment/domain join tests

BUG=682421
TEST=EnterpriseEnrollmentTest.TestActiveDirectoryEnrollment*

Review-Url: https://codereview.chromium.org/2716383002
Cr-Commit-Position: refs/heads/master@{#453253}
Committed:
https://chromium.googlesource.com/chromium/src/+/6dfec867c5ee0e640d48b099ef28...
==========

[commit-bot: I haz the power, 2017-02-27 17:59:32]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6dfec867c5ee0e640d48b099ef28...