Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(799)

Issue 2716363002: Remove out-of-date comment about scoped style resolvers. (Closed)

Created:
3 years, 9 months ago by rune
Modified:
3 years, 9 months ago
Reviewers:
meade_UTC10
CC:
chromium-reviews, blink-reviews-style_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove out-of-date comment about scoped style resolvers. Collecting features is not longer connected to StyleResolver and the comment is no longer correct in any way. The nullptr test is still there because a TreeScope may have stylesheet candidates which do not have style sheets. A candidate is causing the TreeScope to be added to the active list, while it has to have at least one active stylesheet to enforce a ScopedStyleResolver instance. R=meade@chromium.org Review-Url: https://codereview.chromium.org/2716363002 Cr-Commit-Position: refs/heads/master@{#453427} Committed: https://chromium.googlesource.com/chromium/src/+/7660559e277f55e66210695dadc2508deb0bf13d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M third_party/WebKit/Source/core/dom/StyleEngine.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
rune
ptal
3 years, 9 months ago (2017-02-27 15:16:31 UTC) #2
meade_UTC10
lgtm
3 years, 9 months ago (2017-02-27 23:48:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2716363002/1
3 years, 9 months ago (2017-02-28 00:52:42 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 00:59:38 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7660559e277f55e66210695dadc2...

Powered by Google App Engine
This is Rietveld 408576698