[Extensions UI] Initially disabled OK button for extension install prompts.

chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc

Index: chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc
diff --git a/chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc b/chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc
index 0ac3d9395ca43204acb70a7187590c9c9f47ed6b..eb1e42f9b22810895a6a1884c6bf0fb743dd2204 100644
--- a/chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc
+++ b/chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc
@@ -7,6 +7,7 @@
 #include <utility>
 
 #include "base/macros.h"
+#include "base/run_loop.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/extensions/extension_browsertest.h"
 #include "chrome/browser/extensions/extension_icon_manager.h"
@@ -171,6 +172,8 @@ class ExtensionInstallDialogViewTest
     return delegate_view;
   }
 
+  base::OneShotTimer timer;

[Devlin, 2017/03/23 01:25:30]

needed?

[Ackerman, 2017/03/31 22:03:22]

Nope, removed.

+
  private:
   DISALLOW_COPY_AND_ASSIGN(ExtensionInstallDialogViewTest);
 };
@@ -202,3 +205,20 @@ IN_PROC_BROWSER_TEST_F(ExtensionInstallDialogViewTest, NotifyDelegate) {
     EXPECT_EQ(ExtensionInstallPrompt::Result::USER_CANCELED, helper.result());
   }
 }
+
+// Verifies that the "Add extension" button is disabled initally, but enabled
+// after a short time delay.
+IN_PROC_BROWSER_TEST_F(ExtensionInstallDialogViewTest, DelayInstalls) {
+  ExtensionInstallDialogView::SetInstallDelayForTesting(0);
+  ExtensionInstallPromptTestHelper helper;
+  views::DialogDelegateView* delegate_view = CreateAndShowPrompt(&helper);
+
+  // Check initial button states.
+  ASSERT_FALSE(delegate_view->IsDialogButtonEnabled(ui::DIALOG_BUTTON_OK));

[Devlin, 2017/03/23 01:25:30]

nit: we can make these EXPECTs instead of ASSERTs

[Ackerman, 2017/03/31 22:03:22]

Done.

+  ASSERT_TRUE(delegate_view->IsDialogButtonEnabled(ui::DIALOG_BUTTON_CANCEL));
+
+  // Check OK button state after timeout to verify that it is enabled.
+  base::RunLoop().RunUntilIdle();
+  ASSERT_TRUE(delegate_view->IsDialogButtonEnabled(ui::DIALOG_BUTTON_OK));
+  delegate_view->Close();
+}